date: support european dates and out-of-range years by MuntasirSZN · Pull Request #13818 · uutils/coreutils

MuntasirSZN · 2026-08-09T04:14:07Z

date accepts DAY.MONTH[.YEAR] dates (yearless forms use the current
year) and years beyond 9999 with any format. uutils/coreutils rejected both,
failing parts of tests/date/date.pl.

Rewrite european dates to ISO before parsing; accept extended years for
all output formats. Adds unit and integration tests.

tests/date/date.pl gnu test now passes.

Signed-off-by: MuntasirSZN muntasir.joypurhat@gmail.com

codspeed-hq · 2026-08-09T04:23:34Z

Merging this PR will not alter performance

✅ 10 untouched benchmarks
⏩ 408 skipped benchmarks¹

_{Comparing MuntasirSZN:date-pl (f277e47) with main (e0ff0eb)}

408 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2026-08-09T05:12:28Z

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/retry (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/rm/isatty (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/date/date is no longer failing!

collinfunk · 2026-08-09T05:18:58Z

These tests are copied from GNU coreutils and should be licensed as such.

MuntasirSZN · 2026-08-09T05:38:34Z

These tests are copied from GNU coreutils and should be licensed as such.

Ok I gave attribution

xtqqczze · 2026-08-09T09:34:21Z

These tests are copied from GNU coreutils and should be licensed as such.

As per CONTRIBUTING.md, we cannot accept any changes based on the GNU source code. I recommend closing this PR and starting again from scratch.

sylvestre · 2026-08-09T09:58:03Z

yeah, you need to rewrite the tests

MuntasirSZN · 2026-08-09T10:52:46Z

yeah, you need to rewrite the tests

Ok doing it....

github-actions · 2026-08-09T11:50:19Z

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 148.94 MB (+324 KB, +0.21%)

Significant per-binary changes:
  install     1.24 MB ->    1.32 MB  (+80 KB, +6.29%)
  mkdir       1.09 MB ->    1.17 MB  (+80 KB, +7.14%)
  mkfifo      1.09 MB ->    1.16 MB  (+76 KB, +6.83%)
  mknod       1.09 MB ->    1.17 MB  (+76 KB, +6.79%)

MuntasirSZN · 2026-08-09T14:49:24Z

@sylvestre @collinfunk @xtqqczze Sorry for ping, can you guys check now?

xtqqczze · 2026-08-09T15:15:28Z

@MuntasirSZN Could you please confirm that no code in this PR has been derived from GNU coreutils or any other GPL-licensed source, including small snippets, helper structures, test fixtures, or comments?

If you used an AI assistant during development, please also verify its output carefully, as AI-generated code may reproduce material from GPL-licensed sources, potentially without making the provenance apparent.

MuntasirSZN · 2026-08-09T16:37:08Z

@MuntasirSZN Could you please confirm that no code in this PR has been derived from GNU coreutils or any other GPL-licensed source, including small snippets, helper structures, test fixtures, or comments?

If you used an AI assistant during development, please also verify its output carefully, as AI-generated code may reproduce material from GPL-licensed sources, potentially without making the provenance apparent.

No, @xtqqczze. I verified myself.

MuntasirSZN · 2026-08-11T05:41:23Z

@sylvestre @cakebaker review pls? Sorry for ping.

MuntasirSZN · 2026-08-18T05:50:46Z

@sylvestre @cakebaker is there anything else that is needed?

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

MuntasirSZN · 2026-08-22T11:47:59Z

@xtqqczze @sylvestre @cakebaker This is another ping...

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

🟡 Changes recommended

There are correctness and UX issues in the new parsing/formatting paths (e.g., overly-permissive European token matching and incomplete extended-year substitution for format specifiers).

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Files reviewed: 2/2 changed files
Comments generated: 3
Review effort level: Lite

Copilot

🟡 Changes recommended

Extended-year formatting substitution currently misses GNU modifier forms (e.g. %+Y, %10Y) and composite specifiers (e.g. %x), so “any format string” extended-year support is not yet correct/covered.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Files reviewed: 2/2 changed files
Comments generated: 2
Review effort level: Lite

Copilot

🟢 Approval recommended

The changes are well-covered by new tests and look consistent with the stated behavior, with only a minor comment/documentation nit identified.

Review details

Files reviewed: 3/3 changed files
Comments generated: 1
Review effort level: Lite

Copilot

🟡 Changes recommended

The European-date rewrite logic appears to mis-handle separate-year token positioning and 2-digit year semantics compared to GNU/POSIX expectations.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (1)

src/uu/date/src/date.rs:1629

These assertions/documentation currently encode the behavior that 2-digit years are used verbatim (year 99), but GNU/POSIX date treats 2-digit years as 1969–2068. If rewrite_european_date is updated to expand 2-digit years, this test should be updated accordingly.

        // Inline year variants: one or two digits are passed through untouched,
        // longer years are kept whole; a following token (e.g. a timezone) is
        // not consumed as part of the date.
        assert_eq!(rewrite("11.6.99"), "99-06-11");
        assert_eq!(rewrite("11.6.12000"), "12000-06-11");

Files reviewed: 3/3 changed files
Comments generated: 2
Review effort level: Lite

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

`date` accepts DAY.MONTH[.YEAR] dates (yearless forms use the current year) and years beyond 9999 with any format. uutils rejected both, failing parts of tests/date/date.pl. Rewrite european dates to ISO before parsing; accept extended years for all output formats. Adds unit and integration tests. Signed-off-by: MuntasirSZN <muntasir.joypurhat@gmail.com

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

MuntasirSZN force-pushed the date-pl branch from 013576f to 61e7ddf Compare August 9, 2026 04:27

MuntasirSZN force-pushed the date-pl branch from 8cff432 to 7318462 Compare August 9, 2026 10:53

MuntasirSZN force-pushed the date-pl branch 2 times, most recently from c918fea to e991362 Compare August 9, 2026 14:49

MuntasirSZN force-pushed the date-pl branch from e991362 to f81dfbd Compare August 9, 2026 15:03

MuntasirSZN force-pushed the date-pl branch 2 times, most recently from 7362f2a to 5c25094 Compare August 11, 2026 03:19

MuntasirSZN force-pushed the date-pl branch from 5c25094 to 6f704c5 Compare August 20, 2026 02:34

Copilot AI lite review requested due to automatic review settings August 20, 2026 02:34

Copilot AI reviewed Aug 20, 2026

Copilot AI review requested due to automatic review settings August 22, 2026 11:48

Copilot AI reviewed Aug 22, 2026

Copilot AI review requested due to automatic review settings August 23, 2026 05:17

MuntasirSZN force-pushed the date-pl branch from d39da19 to dd6c033 Compare August 23, 2026 05:17

Copilot AI reviewed Aug 23, 2026

MuntasirSZN force-pushed the date-pl branch from dd6c033 to 65e9600 Compare September 5, 2026 10:49

Copilot AI review requested due to automatic review settings September 5, 2026 10:49

Copilot started reviewing on behalf of MuntasirSZN September 5, 2026 10:49 View session

Copilot AI reviewed Sep 5, 2026

View reviewed changes

Comment thread src/uu/date/src/date.rs

Comment thread src/uu/date/src/date.rs Outdated

Comment thread src/uu/date/src/date.rs

Copilot AI review requested due to automatic review settings September 5, 2026 11:07

MuntasirSZN force-pushed the date-pl branch from 65e9600 to e3a17ee Compare September 5, 2026 11:07

Copilot started reviewing on behalf of MuntasirSZN September 5, 2026 11:07 View session

Copilot AI reviewed Sep 5, 2026

View reviewed changes

Comment thread src/uu/date/src/date.rs Outdated

Comment thread tests/by-util/test_date.rs

Copilot AI review requested due to automatic review settings September 5, 2026 11:35

MuntasirSZN force-pushed the date-pl branch from e3a17ee to c4f17ba Compare September 5, 2026 11:35

Copilot started reviewing on behalf of MuntasirSZN September 5, 2026 11:35 View session

Copilot AI reviewed Sep 5, 2026

View reviewed changes

Comment thread src/uu/date/src/date.rs Outdated

Copilot AI review requested due to automatic review settings September 5, 2026 11:43

MuntasirSZN force-pushed the date-pl branch from c4f17ba to 7db97e1 Compare September 5, 2026 11:43

Copilot started reviewing on behalf of MuntasirSZN September 5, 2026 11:44 View session

Copilot AI reviewed Sep 5, 2026

View reviewed changes

Comment thread src/uu/date/src/date.rs Outdated

Comment thread src/uu/date/src/date.rs Outdated

Copilot AI review requested due to automatic review settings September 5, 2026 11:49

Copilot AI reviewed Sep 5, 2026

Copilot AI review requested due to automatic review settings September 5, 2026 11:51

MuntasirSZN force-pushed the date-pl branch from 4885c9b to 7db97e1 Compare September 5, 2026 11:51

Copilot AI reviewed Sep 5, 2026

MuntasirSZN requested a lite review from Copilot September 5, 2026 12:04

Copilot AI reviewed Sep 5, 2026

Copilot AI review requested due to automatic review settings September 5, 2026 12:05

MuntasirSZN force-pushed the date-pl branch from 7db97e1 to f277e47 Compare September 5, 2026 12:05

Copilot AI reviewed Sep 5, 2026

Uh oh!

Uh oh!

Conversation

MuntasirSZN commented Aug 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq Bot commented Aug 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

github-actions Bot commented Aug 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

collinfunk commented Aug 9, 2026

Uh oh!

MuntasirSZN commented Aug 9, 2026

Uh oh!

xtqqczze commented Aug 9, 2026

Uh oh!

sylvestre commented Aug 9, 2026

Uh oh!

MuntasirSZN commented Aug 9, 2026

Uh oh!

github-actions Bot commented Aug 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MuntasirSZN commented Aug 9, 2026

Uh oh!

xtqqczze commented Aug 9, 2026

Uh oh!

MuntasirSZN commented Aug 9, 2026

Uh oh!

MuntasirSZN commented Aug 11, 2026

Uh oh!

MuntasirSZN commented Aug 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

MuntasirSZN commented Aug 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Suppressed comments (1)

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

MuntasirSZN commented Aug 9, 2026 •

edited

Loading

codspeed-hq Bot commented Aug 9, 2026 •

edited

Loading

github-actions Bot commented Aug 9, 2026 •

edited

Loading

github-actions Bot commented Aug 9, 2026 •

edited

Loading