Removed specific Python versions from setup.py#197
Open
WardLT wants to merge 1 commit intouw-cmg:dev_Ryan_2018-10-29from
Open
Removed specific Python versions from setup.py#197WardLT wants to merge 1 commit intouw-cmg:dev_Ryan_2018-10-29from
WardLT wants to merge 1 commit intouw-cmg:dev_Ryan_2018-10-29from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've moved the specific Python versions from the setup.py file and moved them into requirements.txt. This makes it much easier to install mast-ml on my machine (it doesn't uninstall newer versions of packages required by other libraries).
This pattern follows official Python advice: http://packaging.python.org/discussions/install-requires-vs-requirements/
Another thing we could do is limit the packages in the setup.py to only be those directly used in mastml so that we don't specify dependencies of libraries used by mastml.
Does this work for you?