clean up requirements in setup.py#205
Open
martin-hunt wants to merge 3 commits intouw-cmg:masterfrom
Open
Conversation
Add mastml.legos and mastml.search to packages Also move magpie under mastml and add it to the packages. Adjust future_generators.py to find the installed magpie tables.
Author
|
More changes to make this installable. Fixed package list so mastml.legos and mastml.search are installed. Moved 'magpie' to 'mastml/magpie' and added it to package list. Adjusted path in feature_generators.py |
Author
|
Added scikit-optimize as a dependency |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing requirements are a combination of many unrelated packages with a mix of specific old and new versions. I was unsure of the real version requirements so I changed all the "=" to ">=" to permit newer versions. I also removed many packages that appeared unrelated to MASL-ML. I also added keras which is a huge dependency.