This repository was archived by the owner on Oct 26, 2025. It is now read-only.
Soft 389 can rx polling - #289
Draft
Max-MZ wants to merge 7 commits into
Draft
Conversation
ryandancy
approved these changes
Feb 20, 2021
ryandancy
left a comment
ryandancy
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, it's just a matter of if we can get CI to pass lol. I don't think it should affect our test flakiness issues but it's possible.
Collaborator
|
Looks like the change is consistently causing |
Collaborator
|
Update: looks like @jessm's efforts in bypassing vcan in loopback mode fixed the failing test, I'll merge once CI passes. |
There was a very odd race condition in test_can_wake_works where very occasionally it would loop forever. Not sure why, but it also wasn't testing what it was supposed to particularly effectively, so I rewrote it. Also added a couple of x86_interrupt_wake() calls in can_hw to be safe.
ryandancy
marked this pull request as draft
April 4, 2021 17:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
increased timeout on CAN
small change on naming in wait.c