Skip to content
This repository was archived by the owner on Oct 26, 2025. It is now read-only.

[SOFT-501] Uncommitted Protobuf Generated Code Check in CI - #412

Draft
PurpleRhythms wants to merge 90 commits into
masterfrom
soft_501_commit_generated_code
Draft

[SOFT-501] Uncommitted Protobuf Generated Code Check in CI#412
PurpleRhythms wants to merge 90 commits into
masterfrom
soft_501_commit_generated_code

Conversation

@PurpleRhythms

@PurpleRhythms PurpleRhythms commented Jul 7, 2021

Copy link
Copy Markdown
Contributor

See commit comments for details.

Not exactly sure what to write in .md file

Auto generated code from proto files removed from .gitignore
Extended uncommitted codegen checking in CI to also check uncommitted protobuf files.

Added make mu_protos command to build protos for MU

New incomplete .md file for constant comment to post into github.
@PurpleRhythms
PurpleRhythms marked this pull request as draft July 8, 2021 00:12
/usr/local/include/google/protobuf
/usr/local/include/google/protobuf-c
/usr/local/include/protobuf-c
/usr/local/lib

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try and rerun the CI jobs to see if the caching works; if it does, great, but if it doesn't, I worry that caching all of /usr/local/lib will cause issues. I assume there's a particular protobuf library in there that you want to cache, so to cache only that library I'd recommend copying it from /usr/local/lib to some path you can restore (like make ~/.cache/protobuf or something and copy it there) in the install-protobuf step, then copying it back in a step that runs if the cache successfully restored.

@PurpleRhythms

Copy link
Copy Markdown
Contributor Author

Note to self: If check cancels, try again in a couple hours.

@ryandancy

Copy link
Copy Markdown
Collaborator

Note: in order to get the checks to run again you'll need to merge master (and deal with merge conflicts) because the github actions ubuntu-16.04 environment was removed and we've updated it to 18.04 on master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants