This repository was archived by the owner on Oct 26, 2025. It is now read-only.
[SOFT-999] Completed Firmware 102 homework, request for code review - #488
Open
nehemiah-negussie wants to merge 2 commits into
Open
[SOFT-999] Completed Firmware 102 homework, request for code review#488nehemiah-negussie wants to merge 2 commits into
nehemiah-negussie wants to merge 2 commits into
Conversation
nehemiah-negussie
changed the title
mitchellostler
suggested changes
Jan 25, 2022
mitchellostler
left a comment
mitchellostler
left a comment
Contributor
There was a problem hiding this comment.
Looks really well done! There is a simpler design however, that uses only one timer callback function. See if you can figure it out, but if not feel free to ask for help
| uint8_t counter_b; | ||
| } Counters; | ||
|
|
||
| void prv_timer_callback_2(SoftTimerId timer_id, void *context); |
Contributor
There was a problem hiding this comment.
Don't worry about forward declaring your functions, just declare them where you write the function bodies.
This line can go
|
|
||
| void prv_timer_callback_2(SoftTimerId timer_id, void *context); | ||
|
|
||
| void prv_timer_callback(SoftTimerId timer_id, void *context) { |
Contributor
There was a problem hiding this comment.
You can (and should) do all the soft-timer functionality in one timer callback function instead of 2, see if you can figure it out, but if not feel free to ask for help 🙂
Contributor
There was a problem hiding this comment.
Additionally, all private functions in a file should be declared as static, ie static void prv_*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First test commit.