Proximity Limit Switch Library#422
Open
nihal-sahu wants to merge 5 commits into
Open
Conversation
Contributor
|
You have to update the Cmake files as well for your code to get compiled. |
Contributor
|
@nihal-sahu Look good so far, I have left some comments. |
Author
|
I've implemented your comments @jahnavithota2011 |
Member
|
fyi you have build failures. also should probs create a test app and add it to the build matrix: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @jahnavithota2011, can you check my PR so far to see that I am on the right track?