[fix] correct addition of of the spmd submodule to onedal.__all__ to follow proper importing standards#3311
Open
icfaust wants to merge 6 commits into
Open
[fix] correct addition of of the spmd submodule to onedal.__all__ to follow proper importing standards#3311icfaust wants to merge 6 commits into
spmd submodule to onedal.__all__ to follow proper importing standards#3311icfaust wants to merge 6 commits into
Conversation
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
Author
|
/intelci: run |
Contributor
Author
|
/intelci: run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Should correct issues of importing using
from onedal import *when an spmd backend is available and someone actually wants to use it that way. Doing sub sub modules in an all will mess with things. (https://docs.python.org/3/tutorial/modules.html#importing-from-a-package)Checklist:
Completeness and readability
Testing
Performance