Update Cobbler settings file to a new dedicated path (bsc#1244027) - #628
Merged
Conversation
Use settings.d/zz-uyuni.settings instead of settings.yaml
vzhestkov
approved these changes
Jul 14, 2025
vzhestkov
left a comment
vzhestkov
left a comment
Contributor
There was a problem hiding this comment.
In general looks good for me, just a bit nitpicky coment in the code.
aaannz
approved these changes
Jul 17, 2025
aaannz
approved these changes
Jul 21, 2025
|
Contributor
|
Hmm.. we all talked about optimizing |
Contributor
|
Fixed as part of #650 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This PR makes "uyuni-tools" to use a dedicated settings file for Cobbler, instead of the main
settings.yamlwhich should be only containing default settings values.This should be merged in coordination with these other PRs:
uyuni-project/uyuni#10585
openSUSE/cobbler#135
Codespace
Check if you already have a running container clicking on
Test coverage
No tests: no tests around migrate scripts
DONE
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/27412
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Before you merge
Check How to branch and merge properly!