Generate template only after secrets are created - #771
Merged
mcalmer merged 2 commits intoApr 21, 2026
Conversation
mbussolotto
requested changes
Apr 21, 2026
mbussolotto
approved these changes
Apr 21, 2026
mbussolotto
reviewed
Apr 21, 2026
To avoid reusing old passwords, we need to force recreating user secrets if they are already present. Uninstall also did not remove those secrets, fixed. This commit also adjust heatlhcheck timeout to 5 minutes as the server container can now take a while until it is ready.
aaannz
force-pushed
the
fix_missing_secrets_on_upgrade
branch
from
April 21, 2026 08:59
1436235 to
7e1b6ed
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Codespace
Check if you already have a running container clicking on
Test coverage
No tests: add explanation
DONE
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/30380
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Before you merge
Check How to branch and merge properly!