Check and warn if CA certificate isn't marked as critical#804
Merged
Conversation
mcalmer
approved these changes
Jun 1, 2026
3 tasks
Contributor
|
Double work, see: #803 |
cbosdo
approved these changes
Jun 2, 2026
marv7000
force-pushed
the
warn-if-not-critical
branch
from
June 2, 2026 08:38
f4d5b9e to
49c872b
Compare
|
aaannz
approved these changes
Jun 2, 2026
Contributor
|
I just noticed, the merge target branch is strange. Why not merging to |
Contributor
Author
|
@mcalmer has asked me to target this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Issue a warning if a CA is not marked as
critical. See https://datatracker.ietf.org/doc/html/rfc5280 for details.Codespace
Check if you already have a running container clicking on
Test coverage
No tests: already covered
DONE
Links
Issue(s): #
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Before you merge
Check How to branch and merge properly!