feat: add automatic formik form submission#129
Conversation
…k onChange function
WalkthroughWalkthroughThe changes introduce a new dependency, Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
size-limit report 📦
|
There was a problem hiding this comment.
Actionable comments posted: 3
Outside diff range, codebase verification and nitpick comments (1)
src/forms/FormikAutoSubmit.stories.tsx (1)
1-35: Replace alert with a more realistic action.Using
alertin theonSubmithandler is not ideal for real-world applications. Consider replacing it withconsole.logor a more realistic action, such as an API call or state update.- alert(`Form submitted with value: ${values.name}`) + console.log(`Form submitted with value: ${values.name}`)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
Files selected for processing (3)
- package.json (1 hunks)
- src/forms/FormikAutoSubmit.stories.tsx (1 hunks)
- src/forms/FormikAutoSubmit.tsx (1 hunks)
Files skipped from review due to trivial changes (1)
- package.json
fixes old values in formik onChange function
issues:
jaredpalmer/formik#2106
jaredpalmer/formik#2083
future fix: jaredpalmer/formik#3947