Skip to content

chore(deps): update design-system to support year and month dropdowns in datepicker components#4957

Merged
sjschlapbach merged 3 commits into
v3from
update-design-system-calendar-dropdowns
Oct 28, 2025
Merged

chore(deps): update design-system to support year and month dropdowns in datepicker components#4957
sjschlapbach merged 3 commits into
v3from
update-design-system-calendar-dropdowns

Conversation

@sjschlapbach

@sjschlapbach sjschlapbach commented Oct 26, 2025

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated design system component library across applications and packages to version 4.1.6.
    • Enhanced build configuration for improved module resolution and transpilation support.

@coderabbitai

coderabbitai Bot commented Oct 26, 2025

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

This PR updates the @uzh-bf/design-system dependency from version 4.1.4 to 4.1.6 across nine package.json files in the monorepo. Additionally, it modifies webpack configuration in the next-config package to conditionally set resolution conditions and includes the design-system package in the transpilePackages list.

Changes

Cohort / File(s) Change Summary
Application Dependencies
apps/auth/package.json, apps/chat/package.json, apps/frontend-control/package.json, apps/frontend-manage/package.json, apps/frontend-pwa/package.json, apps/office-addin/package.json
Bumped @uzh-bf/design-system from 4.1.4 to 4.1.6
Documentation App
apps/docs/package.json
Updated @uzh-bf/design-system devDependency from 4.1.4 to 4.1.6
Package Dependencies
packages/markdown/package.json, packages/shared-components/package.json
Updated @uzh-bf/design-system peerDependency from 4.1.4 to 4.1.6
Transactional Package
packages/transactional/package.json
Updated @uzh-bf/design-system devDependency from 4.1.4 to 4.1.6
Webpack Configuration
packages/next-config/index.js
Added conditional webpack resolution logic to prioritize Node-specific exports for server builds and development context for client builds; added @uzh-bf/design-system to transpilePackages list

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • All dependency bumps follow a consistent pattern across multiple files (version change from 4.1.4 to 4.1.6)
  • Webpack configuration changes in packages/next-config/index.js should be verified to ensure the conditional resolution logic functions as intended

Possibly related PRs

Suggested labels

dependencies

Suggested reviewers

  • rschlaefli

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "chore(deps): update design-system to support year and month dropdowns in datepicker components" is directly related to the main changes in the changeset. The raw summary confirms that the primary change is a version bump of the "@uzh-bf/design-system" dependency from 4.1.4 to 4.1.6 across multiple applications and packages, along with a webpack configuration adjustment to support the updated package. The title clearly and specifically communicates both what is being changed (the design-system dependency) and the purpose behind the update (supporting new datepicker functionality), making it easy for reviewers to understand the intent of the PR at a glance.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ca181ec and 181cf22.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (11)
  • apps/auth/package.json (1 hunks)
  • apps/chat/package.json (1 hunks)
  • apps/docs/package.json (1 hunks)
  • apps/frontend-control/package.json (1 hunks)
  • apps/frontend-manage/package.json (1 hunks)
  • apps/frontend-pwa/package.json (1 hunks)
  • apps/office-addin/package.json (1 hunks)
  • packages/markdown/package.json (1 hunks)
  • packages/next-config/index.js (2 hunks)
  • packages/shared-components/package.json (1 hunks)
  • packages/transactional/package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: cypress-run-cloud
  • GitHub Check: build
  • GitHub Check: Analyze (javascript)
  • GitHub Check: build
  • GitHub Check: build
  • GitHub Check: SonarCloud
  • GitHub Check: build
  • GitHub Check: build
  • GitHub Check: test
  • GitHub Check: build
🔇 Additional comments (13)
packages/markdown/package.json (1)

43-43: Version bump is consistent with monorepo-wide update.

The @uzh-bf/design-system peerDependency is correctly bumped to 4.1.6. Note that this uses a fixed version constraint unlike other peer dependencies in the file (which use caret ranges). This is intentional for library packages, though you may want to verify this aligns with your versioning strategy.

apps/frontend-control/package.json (1)

21-21: Version bump is consistent with monorepo-wide update.

The @uzh-bf/design-system dependency is correctly bumped to 4.1.6 across all app packages.

apps/chat/package.json (1)

26-26: Version bump is consistent with monorepo-wide update.

The @uzh-bf/design-system dependency is correctly bumped to 4.1.6.

packages/shared-components/package.json (1)

36-36: Version bump is consistent with monorepo-wide update.

The @uzh-bf/design-system peerDependency is correctly bumped to 4.1.6, following the same fixed version pattern as packages/markdown.

packages/transactional/package.json (1)

11-11: Version bump is consistent with monorepo-wide update.

The @uzh-bf/design-system devDependency is correctly bumped to 4.1.6 for email template generation.

apps/office-addin/package.json (1)

6-6: Version bump is consistent with monorepo-wide update.

The @uzh-bf/design-system dependency is correctly bumped to 4.1.6.

apps/auth/package.json (1)

15-15: Version bump is consistent with monorepo-wide update.

The @uzh-bf/design-system dependency is correctly bumped to 4.1.6.

apps/frontend-manage/package.json (2)

29-29: Version bump is consistent with monorepo-wide update.

The @uzh-bf/design-system dependency is correctly bumped to 4.1.6 across all frontend packages.


1-110: Verify design system compatibility and webpack configuration completeness.

All package.json files have been consistently updated to @uzh-bf/design-system 4.1.6. The PR title mentions "year and month dropdowns in datepicker components," but the specific changes and any potential breaking changes in this version are not apparent from the provided code. Additionally, the AI summary references webpack configuration changes in packages/next-config/index.js that enable transpilation and conditional resolution for the design system, but that file is not included in this review.

To ensure this update is complete and safe, please verify:

  1. Whether the @uzh-bf/design-system 4.1.6 release notes confirm the datepicker dropdown features and any breaking changes
  2. Whether the packages/next-config/index.js changes are included in this PR and are compatible with the design-system update
apps/docs/package.json (1)

26-26: LGTM! Consistent version bump across the monorepo.

The devDependency version bump is consistent with the changes in other packages and appropriate for the docs application.

packages/next-config/index.js (2)

20-28: Clarify the relationship between webpack changes and PR objectives.

The conditional resolution logic references PayloadCMS and file-type dependencies, which don't appear related to the datepicker dropdown functionality mentioned in the PR title. Please clarify:

  1. Are these webpack changes required for the new design-system version (4.1.6) to work correctly?
  2. Or are these unrelated build configuration fixes being bundled with the design-system update?

If these changes are unrelated to the design-system update, consider splitting them into a separate PR for better traceability.


39-39: Good addition to support the design-system package.

Adding @uzh-bf/design-system to transpilePackages is necessary for proper integration of the external package in the Next.js build process.

apps/frontend-pwa/package.json (1)

28-28: I need to search for the actual release notes and changelog information. Let me perform a targeted web search:

Let me search more specifically for the npm registry entry and GitHub releases for this package:

Verify that version 4.1.6 includes expected datepicker functionality and contains no breaking changes.

I was unable to retrieve detailed release notes or changelog information for @uzh-bf/design-system versions 4.1.4 and 4.1.6 through public sources. While the npm package exists, specific version-to-version changes are not documented in publicly accessible locations. Please manually verify:

  • That 4.1.6 includes the year and month dropdown functionality for datepicker components referenced in the PR
  • Any breaking changes or behavioral differences between 4.1.4 and 4.1.6 by checking the repository's release page or release notes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sjschlapbach sjschlapbach marked this pull request as ready for review October 28, 2025 12:27
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 28, 2025
@sjschlapbach sjschlapbach enabled auto-merge (squash) October 28, 2025 12:27
@sonarqubecloud

Copy link
Copy Markdown

@cypress

cypress Bot commented Oct 28, 2025

Copy link
Copy Markdown

klicker-uzh    Run #6506

Run Properties:  status check failed Failed #6506  •  git commit 831cc1c9d3 ℹ️: Merge 181cf22c716aa21b11022e61348dbbe46cafd710 into ca181ec45e1705adcd58c9fae312...
Project klicker-uzh
Branch Review update-design-system-calendar-dropdowns
Run status status check failed Failed #6506
Run duration 09m 37s
Commit git commit 831cc1c9d3 ℹ️: Merge 181cf22c716aa21b11022e61348dbbe46cafd710 into ca181ec45e1705adcd58c9fae312...
Committer Julius Schlapbach
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 756
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/Q-practice-quiz-workflow.cy.ts • 2 failed tests

View Output Video

Test Artifacts
Different practice quiz workflows > Publish the future practice quiz and verify scheduled state Test Replay Screenshots Video
Different practice quiz workflows > Unpublish the practice quiz again on the lecturer view Test Replay Screenshots Video
Flakiness  cypress/e2e/L-elements-case-study-workflow.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Test creation and editing functionalities, validation, etc. for case study elements > Verify that the case study validation logic covers all required cases and block submission of invalid element edit modals Test Replay Screenshots Video

@sjschlapbach sjschlapbach disabled auto-merge October 28, 2025 14:32
@sjschlapbach sjschlapbach merged commit e642b71 into v3 Oct 28, 2025
32 of 45 checks passed
@sjschlapbach sjschlapbach deleted the update-design-system-calendar-dropdowns branch October 28, 2025 14:32
@cypress

cypress Bot commented Oct 28, 2025

Copy link
Copy Markdown

klicker-uzh    Run #6507

Run Properties:  status check failed Failed #6507  •  git commit e642b71c8e: chore(deps): update design-system to support year and month dropdowns in datepic...
Project klicker-uzh
Branch Review v3
Run status status check failed Failed #6507
Run duration 10m 05s
Commit git commit e642b71c8e: chore(deps): update design-system to support year and month dropdowns in datepic...
Committer Julius Schlapbach
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 756
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/Q-practice-quiz-workflow.cy.ts • 2 failed tests

View Output Video

Test Artifacts
Different practice quiz workflows > Publish the future practice quiz and verify scheduled state Test Replay Screenshots Video
Different practice quiz workflows > Unpublish the practice quiz again on the lecturer view Test Replay Screenshots Video
Flakiness  cypress/e2e/F-elements-sc-workflow.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Test creation and editing functionalities, validation, etc. for Single Choice elements > Edit the single choice question again and add answer feedbacks Test Replay Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Development

Successfully merging this pull request may close these issues.

2 participants