update devcontainer and lockfile#23
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refreshes development environment settings and updates the OPAM lockfile to newer package versions.
- Bump numerous OCaml package versions in
guardian.opam.locked - Remove host SSH/Git mounts and switch sandbox mode in the Dev Container
- Standardize
ENVsyntax in the Dockerfile
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| guardian.opam.locked | Updated a wide range of package versions in the lockfile |
| .devcontainer/docker-compose.yml | Removed SSH and Git config volume mounts |
| .devcontainer/devcontainer.json | Changed OCaml sandbox kind from opam to global |
| .devcontainer/Dockerfile | Switched ENV syntax to KEY=VALUE form |
Comments suppressed due to low confidence (3)
.devcontainer/docker-compose.yml:13
- By removing the SSH mount, contributors lose SSH access inside the container; consider adding documentation about alternative authentication methods or optional mounting instructions.
- build:/workspace/_build:cached
.devcontainer/devcontainer.json:38
- [nitpick] Switching the OCaml sandbox from
opamtoglobalchanges dependency isolation behavior; update the README or add a comment explaining the new workflow for contributors.
"kind": "global"
guardian.opam.locked:109
- [nitpick] The
& with-docconstraint was removed from theresultpackage; if building documentation is required, consider re-adding it to ensure docs are generated.
"result" {= "1.5"}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.