Skip to content

fix: sync editor value to server when same value is typed again (#9568) (CP: 25.2) #9572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sissbruecker merged 1 commit into from
Jun 22, 2026
Merged

fix: sync editor value to server when same value is typed again (#9568) (CP: 25.2) #9572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...-parent/vaadin-grid-pro-flow/src/main/java/com/vaadin/flow/component/gridpro/GridPro.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ private void setup() {
var itemKey = getDataCommunicator().getKeyMapper()
.key(e.getItem());
UI.getCurrentOrThrow().getPage().executeJs(
"window.Vaadin.Flow.gridProConnector.selectAll($0, $1, $2)",
"window.Vaadin.Flow.gridProConnector.handleCustomEditorValueUpdate($0, $1, $2)",
column.getEditorField().getElement(), itemKey,
this.getElement());
}
Expand Down
18 changes: 17 additions & 1 deletion ...t/vaadin-grid-pro-flow/src/main/resources/META-INF/resources/frontend/gridProConnector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
* See <https://vaadin.com/commercial-license-and-service-terms> for the full
* license.
*/
import { isFirefox } from '@vaadin/component-base/src/browser-utils.js';
import { iterateRowCells, updatePart } from '@vaadin/grid/src/vaadin-grid-helpers.js';

function isEditedRow(grid, rowData) {
Expand All @@ -16,7 +17,7 @@ function isEditedRow(grid, rowData) {
const LOADING_EDITOR_CELL_ATTRIBUTE = 'loading-editor';

window.Vaadin.Flow.gridProConnector = {
selectAll: (editor, itemKey, grid) => {
handleCustomEditorValueUpdate: (editor, itemKey, grid) => {
if (editor.__itemKey !== itemKey) {
// This is an outdated call that can occur if the user starts editing a cell,
// and quickly starts editing another cell on the same column before the editor
Expand Down Expand Up @@ -61,6 +62,21 @@ window.Vaadin.Flow.gridProConnector = {
stopCellEdit.apply(this, arguments);
this._grid.toggleAttribute(LOADING_EDITOR_CELL_ATTRIBUTE, false);
};

if (isFirefox && !component.__firefoxChangeWorkaroundInstalled) {
// The editor is focused before its value is set from the server. Firefox
// treats an input as unchanged when its value on blur equals the value it
// had on focus, ignoring programmatic changes in between. So typing the
// value from the previous edit again would not fire a change event and
// the cell would not update. As a workaround, always fire a synthetic
// change event when an input loses focus.
component.addEventListener('focusout', (e) => {
if (e.target instanceof HTMLInputElement) {
e.target.dispatchEvent(new Event('change', { bubbles: true }));
}
});
component.__firefoxChangeWorkaroundInstalled = true;
}
},

patchEditModeRenderer(column) {
Expand Down
Loading