fix: allow filtering out all values in spreadsheet filter#9574
Merged
Conversation
vursen
force-pushed
the
fix/spreadsheet-select-all-filter-state
branch
from
5d2b946 to
3a297a5
Compare
vursen
changed the title
vursen
force-pushed
the
fix/spreadsheet-select-all-filter-state
branch
2 times, most recently
from
939c532 to
161135b
Compare
Unchecking "(Select All)", or unchecking individual values down to none, did not hide the matching rows in a filtered column. The selection looked cleared but no filtering happened, and closing the popup reverted the checkboxes back to all-selected, so a column's values could never be fully filtered out. Unchecking now hides the corresponding rows and the deselected state persists: the "Select All" handler filters all rows on an empty selection, the value-change listener always updates filtered rows (including when empty), and the popup-close revert is removed. Because the deselected state now persists, updateOptions uses three-state logic so reopening the popup shows the checkbox unchecked instead of indeterminate. "(Select All)" is also hidden when all of a column's values are already hidden by other columns' filters. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
vursen
force-pushed
the
fix/spreadsheet-select-all-filter-state
branch
from
161135b to
f5f1669
Compare
vursen
changed the title
|
sissbruecker
approved these changes
Jun 22, 2026
Collaborator
|
Hi @vursen and @sissbruecker, when i performed cherry-pick to this commit to 25.1, i have encountered the following issue. Can you take a look and pick it manually? |
sissbruecker
added a commit
that referenced
this pull request
Jun 22, 2026
…9577) This PR cherry-picks changes from the original PR #9574 to branch 25.1. --- > In the spreadsheet filter popup, unchecking "Select All" had no effect, and when unchecking values one by one, the last one didn't do anything either. The selection looked empty, but no filtering happened, and after closing the popup everything was selected again, which was confusing. > > Unchecking now hides the rows and the deselected state persists. The PR also hides the "Select All" checkbox entirely when all of a column's values are already filtered out by other columns. > > Fixes #9549 > > 🤖 Generated with Claude Code Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
sissbruecker
pushed a commit
that referenced
this pull request
Jun 22, 2026
…: 25.2) (#9576) This PR cherry-picks changes from the original PR #9574 to branch 25.2. --- #### Original PR description > In the spreadsheet filter popup, unchecking "Select All" had no effect, and when unchecking values one by one, the last one didn't do anything either. The selection looked empty, but no filtering happened, and after closing the popup everything was selected again, which was confusing. > > Unchecking now hides the rows and the deselected state persists. The PR also hides the "Select All" checkbox entirely when all of a column's values are already filtered out by other columns. > > Fixes #9549 > > 🤖 Generated with Claude Code > Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the spreadsheet filter popup, unchecking "Select All" had no effect, and when unchecking values one by one, the last one didn't do anything either. The selection looked empty, but no filtering happened, and after closing the popup everything was selected again, which was confusing.
Unchecking now hides the rows and the deselected state persists. The PR also hides the "Select All" checkbox entirely when all of a column's values are already filtered out by other columns.
Fixes #9549
🤖 Generated with Claude Code