chore: remove unused spreadsheet-client callback interfaces#9728
Merged
Conversation
The 44 callback interfaces and the commented-out test block were dead: the live event path uses SpreadsheetServerRpcImpl.JsConsumer<T> and nothing imported the callbacks package. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
web-padawan
approved these changes
Jul 13, 2026
|
vursen
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GWT spreadsheet client keeps 44 callback interface classes that nothing
uses. The live event path passes JS functions as
SpreadsheetServerRpcImpl.JsConsumer<T>, so these typed callbacks are aleftover from an earlier design. Their names line up with the callback
setter methods (
setCellSelectedCallback, …), which misleads readers intothinking they are the live wiring when they are not.
Delete the
callbacks/package (44 files) and the commented-out test blockin
SpreadsheetJsApiTestthat referenced those types. No behavior change:the package had zero imports anywhere, and the deleted tests were inside a
block comment. The client module still compiles and its unit tests pass.
🤖 Generated with Claude Code