Skip to content

updated valkey version #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bloodraven21 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

updated valkey version #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/valkeycluster.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ An explicit value is honoured as-is, even if it is below the recommended minimum
### Private image registries

```yaml
image: registry.example.com/valkey/valkey:9.0.0
image: registry.example.com/valkey/valkey:9.1.1
imagePullSecrets:
- name: registrycredential
```
Expand Down
2 changes: 1 addition & 1 deletion internal/controller/valkeycluster_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ import (
const (
DefaultPort = 6379
DefaultClusterBusPort = 16379
DefaultImage = "valkey/valkey:9.0.0"
DefaultImage = "valkey/valkey:9.1.1"
Comment thread
sandeepkunusoth marked this conversation as resolved.
DefaultExporterImage = "oliver006/redis_exporter:v1.80.0"
DefaultExporterPort = 9121

Expand Down
4 changes: 2 additions & 2 deletions internal/controller/valkeycluster_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -921,7 +921,7 @@ var _ = Describe("reconcileValkeyNodes", func() {
Spec: valkeyiov1alpha1.ValkeyClusterSpec{
Shards: 2,
Replicas: 1,
Image: "valkey/valkey:9.0.0",
Image: "valkey/valkey:9.1.1",
WorkloadType: valkeyiov1alpha1.WorkloadTypeStatefulSet,
},
}
Expand Down Expand Up @@ -1156,7 +1156,7 @@ var _ = Describe("reconcileValkeyNode", func() {
Spec: valkeyiov1alpha1.ValkeyClusterSpec{
Shards: 1,
Replicas: 0,
Image: "valkey/valkey:9.0.0",
Image: "valkey/valkey:9.1.1",
WorkloadType: valkeyiov1alpha1.WorkloadTypeStatefulSet,
},
}
Expand Down
10 changes: 5 additions & 5 deletions internal/controller/valkeynode_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -914,7 +914,7 @@ var _ = Describe("isWorkloadRolledOut", func() {
Selector: &metav1.LabelSelector{MatchLabels: map[string]string{"app": nodeName}},
Template: corev1.PodTemplateSpec{
ObjectMeta: metav1.ObjectMeta{Labels: map[string]string{"app": nodeName}},
Spec: corev1.PodSpec{Containers: []corev1.Container{{Name: "c", Image: "valkey/valkey:9.0.0"}}},
Spec: corev1.PodSpec{Containers: []corev1.Container{{Name: "c", Image: "valkey/valkey:9.1.1"}}},
},
},
}
Expand All @@ -939,7 +939,7 @@ var _ = Describe("isWorkloadRolledOut", func() {
Selector: &metav1.LabelSelector{MatchLabels: map[string]string{"app": node2.Name}},
Template: corev1.PodTemplateSpec{
ObjectMeta: metav1.ObjectMeta{Labels: map[string]string{"app": node2.Name}},
Spec: corev1.PodSpec{Containers: []corev1.Container{{Name: "c", Image: "valkey/valkey:9.0.0"}}},
Spec: corev1.PodSpec{Containers: []corev1.Container{{Name: "c", Image: "valkey/valkey:9.1.1"}}},
},
},
}
Expand Down Expand Up @@ -972,7 +972,7 @@ var _ = Describe("isWorkloadRolledOut", func() {
Selector: &metav1.LabelSelector{MatchLabels: map[string]string{"app": node3.Name}},
Template: corev1.PodTemplateSpec{
ObjectMeta: metav1.ObjectMeta{Labels: map[string]string{"app": node3.Name}},
Spec: corev1.PodSpec{Containers: []corev1.Container{{Name: "c", Image: "valkey/valkey:9.0.0"}}},
Spec: corev1.PodSpec{Containers: []corev1.Container{{Name: "c", Image: "valkey/valkey:9.1.1"}}},
},
},
}
Expand Down Expand Up @@ -1007,7 +1007,7 @@ var _ = Describe("isWorkloadRolledOut", func() {
Selector: &metav1.LabelSelector{MatchLabels: map[string]string{"app": nodeName}},
Template: corev1.PodTemplateSpec{
ObjectMeta: metav1.ObjectMeta{Labels: map[string]string{"app": nodeName}},
Spec: corev1.PodSpec{Containers: []corev1.Container{{Name: "c", Image: "valkey/valkey:9.0.0"}}},
Spec: corev1.PodSpec{Containers: []corev1.Container{{Name: "c", Image: "valkey/valkey:9.1.1"}}},
},
},
}
Expand All @@ -1032,7 +1032,7 @@ var _ = Describe("isWorkloadRolledOut", func() {
Selector: &metav1.LabelSelector{MatchLabels: map[string]string{"app": node2.Name}},
Template: corev1.PodTemplateSpec{
ObjectMeta: metav1.ObjectMeta{Labels: map[string]string{"app": node2.Name}},
Spec: corev1.PodSpec{Containers: []corev1.Container{{Name: "c", Image: "valkey/valkey:9.0.0"}}},
Spec: corev1.PodSpec{Containers: []corev1.Container{{Name: "c", Image: "valkey/valkey:9.1.1"}}},
},
},
}
Expand Down
4 changes: 2 additions & 2 deletions internal/controller/valkeynode_resources_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func newTestValkeyNode(name, namespace string) *valkeyv1.ValkeyNode {
Namespace: namespace,
},
Spec: valkeyv1.ValkeyNodeSpec{
Image: "valkey/valkey:9.0.0",
Image: "valkey/valkey:9.1.1",
ServerConfigMapName: "valkey-config",
},
}
Expand Down Expand Up @@ -73,7 +73,7 @@ func TestBuildValkeyNodePodTemplateSpec(t *testing.T) {
assert.Equal(t, "server", c.Name)

// Image
assert.Equal(t, "valkey/valkey:9.0.0", c.Image)
assert.Equal(t, "valkey/valkey:9.1.1", c.Image)

// Command
assert.Equal(t, []string{"valkey-server", "/config/valkey.conf",
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/e2e_suite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const metricsServiceName = "valkey-operator-controller-manager-metrics-service"
const metricsRoleBindingName = "valkey-operator-metrics-binding"

// valkeyClientImage is the image used to verify cluster access.
const valkeyClientImage = "valkey/valkey:9.0.0"
const valkeyClientImage = "valkey/valkey:9.1.1"

var (
// managerImage is the manager image to be built and loaded for testing.
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/valkeynode_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ spec:

By("patching the ValkeyNode spec to increment the generation")
patchCmd := exec.Command("kubectl", "patch", "valkeynode", nodeName,
"--type=merge", "-p", `{"spec":{"image":"valkey/valkey:9.0.0"}}`)
"--type=merge", "-p", `{"spec":{"image":"valkey/valkey:9.1.1"}}`)
_, err = utils.Run(patchCmd)
Expect(err).NotTo(HaveOccurred())

Expand Down