feat(acl): allow config|get for auditability - #341
Conversation
Signed-off-by: Tim Karger <tkarger@users.noreply.github.com> Remove unrequired annotations Signed-off-by: Tim Karger <49390121+tkarger@users.noreply.github.com>
|
| Filename | Overview |
|---|---|
| internal/controller/users.go | Adds the narrowly scoped `+config |
Reviews (1): Last reviewed commit: "feat(acl): allow config|get for auditabi..." | Re-trigger Greptile
|
Thanks for raising - I left a comment on the issue on what underlying bug we're trying to solve. |
|
this one's independently correct regardless of where the broader #335 discussion lands: read-only, no new write surface, and it closes the write-without-read audit gap. it's also useful to the operator itself, the live-config apply path can read a key back after |
This PR closes #335
Summary
The
_operatoruser had only the permission toCONFIG SET, not toCONFIG GET. Due to this limitation the user wasn't able to retrieve the current configurations of the cluster and audit the state.Features / Behaviour Changes
The
_operatoruser can check the applied settings of the valkey instance and audit changesImplementation
The permisson for
config|getwas added to the_operatoruser.Testing
Tested by e2e tests
Checklist
Before submitting the PR make sure the following are checked:
pre-commit run --all-filesor hooks on commit)