feat: Add args configuration support to exporter - #345
Draft
nantiferov wants to merge 1 commit into
Draft
Conversation
nantiferov
force-pushed
the
feat--Add-args-configuration-support-to-exporter
branch
2 times, most recently
from
August 1, 2026 15:28
d203532 to
24bb9c5
Compare
As discussed in valkey-io#331, I'm moving here default args for exporter to ENV variables, so they could be overwritten if needed. As well added ExporterSpec.Args to pass args: to exported spec. Signed-off-by: Nicolai Antiferov <nicolai.antiferov@bolt.eu>
nantiferov
force-pushed
the
feat--Add-args-configuration-support-to-exporter
branch
from
August 1, 2026 15:30
24bb9c5 to
ebd4524
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #331
Summary
As discussed in #331, I'm moving here default args for exporter to ENV variables, so they could be overwritten if needed.
As well added ExporterSpec.Args to pass args: to exported spec.
Features / Behaviour Changes
No behaviour changes. Existing args passed to exporter replaced with ENV variable with same values.
Implementation
internal/controller/valkeynode_resources_test.goto test new functionalityLimitations
None
Testing
Unit tests passed
Checklist
Before submitting the PR make sure the following are checked:
pre-commit run --all-filesor hooks on commit)