fixed e2e test failing on main branch as config get is allowed by operator users

[sandeepkunusoth]

Summary

#341 addes +config|get to operator ACL. Fixes the failing e2e test on main https://github.com/valkey-io/valkey-operator/actions/runs/30701407296/job/91372936404
#245 added e2e test that asserts these commands return NOPERM for operator user

Changes

• update e2e test to add Config GET to allowed list and removed it from disallowed check.

Testing

tested on local kind cluster by running multiple times.

Checklist

Before submitting the PR make sure the following are checked:

• This Pull Request is related to one issue.
• Commit message explains what changed and why
• Tests are added or updated.
• Documentation files are updated.
• I have run pre-commit locally (pre-commit run --all-files or hooks on commit)

[coderabbitai]

📝 Walkthrough

Walkthrough

The E2E operator-user permission test now allows CONFIG GET maxmemory and removes CONFIG GET * from the denied-command sequence.

Changes

Operator permissions

Layer / File(s)	Summary
Operator command permission validation test/e2e/valkeycluster_test.go	The allowed command sequence includes CONFIG GET maxmemory. The denied-command sequence no longer includes CONFIG GET *.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly describes the fix to the E2E test caused by CONFIG GET being allowed for operator users.
Description check	✅ Passed	The description explains the change, references related issues, documents testing, and includes the checklist.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@test/e2e/valkeycluster_test.go`:
- Line 587: Update the comment describing the command sequence near CONFIG GET
maxmemory to state that commands with arguments are also tested, matching the
actual sequence and removing the inaccurate “without arguments” wording.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8d335249-7d39-4653-865a-5beec9e924e6

📥 Commits

Reviewing files that changed from the base of the PR and between 19d2d6d and ab7cf85.

📒 Files selected for processing (1)

• test/e2e/valkeycluster_test.go

[greptile-apps]

Greptile Summary

Updates the operator-user E2E ACL coverage so that CONFIG GET maxmemory is expected to succeed, and removes the obsolete expectation that CONFIG GET * is denied.

The prior wildcard-denial behavior was exercised against Valkey 9.0.0 with the repository’s _operator ACL: CONFIG GET * returned configuration data, while SET was denied. The revised CONFIG GET maxmemory assertion matches the actual permission boundary.

Merge safety: safe to merge.

Confidence Score: 5/5

T-Rex Logs

What T-Rex did

• The before-capture proved that the old E2E expectation is invalid because CONFIG GET * returns configuration entries instead of NOPERM.
• The after-capture showed that CONFIG GET maxmemory returns maxmemory / 0 and CONFIG GET * returns real configuration entries, while the _operator still receives NOPERM on SET.
• Validation used a locally built Valkey 9.0.0 server/CLI because Docker, Kind, kubectl, and preinstalled Valkey binaries were unavailable.
• Validation also used the repository's actual ACL contract as the basis for evaluating permission behavior.

_{Ran code and verified through T-Rex}

_{Reviews (2): Last reviewed commit: "fixed e2e test failing as config get is ..." | Re-trigger Greptile}