(chore) enable github merge queue - #354
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughThe lint, test, and E2E GitHub Actions workflows now run for ChangesMerge queue CI
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Signed-off-by: Sandeep Kunusoth <sandeepkunsoth000@gmail.com>
Signed-off-by: Sandeep Kunusoth <sandeepkunsoth000@gmail.com>
befa81c to
18d3e21
Compare
jdheyburn
left a comment
There was a problem hiding this comment.
I think this is fair given that its the second time we've seen main broken.
The alternative is to require PRs to pull from main before merge, which I don't think creates a great DX given the time it takes to run e2e tests.
Will leave this approved but unmerged to let other folks comment.
This PR fixes #353
Summary
Enables github merge queue. to avoid main branch brokwn state in future.
Changes
Implementation
Limitations
Testing
Actions needed from maintainer After this PR is merged:
main.MERGE15 minutesALLGREENe2e testsCheck formattingCheck go.modRun lintersverify generated codeChecklist
Before submitting the PR make sure the following are checked:
pre-commit run --all-filesor hooks on commit)