Skip to content

test: update operator-user ACL e2e for the config|get grant #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matka12 wants to merge 1 commit into from
Closed

test: update operator-user ACL e2e for the config|get grant #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions test/e2e/valkeycluster_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,8 +583,9 @@ CLUSTER MYID
CLUSTER MYSHARDID
CLUSTER NODES
CLUSTER FAILOVER
CONFIG GET maxmemory
INFO
ROLE
ROLE
EOF`,
clusterFqdn,
operatorPassword,
Expand Down Expand Up @@ -626,12 +627,16 @@ EOF`,
g.Expect(err).NotTo(HaveOccurred())
operatorPassword := string(decoded)

// CONFIG GET is intentionally absent: the _operator user is
// granted +config|get for auditability (#341), covered by the
// allowed-commands check above (+config|set is granted too,
// so neither CONFIG subcommand belongs here).

@jdheyburn jdheyburn Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this comment, I don't see why we would specifically call out CONFIG GET and not any of the other commands in this list.

disallowedCommands := []string{
"SET foo bar",
"GET foo",
"DEL foo",
"KEYS *",
"CONFIG GET *",
"FLUSHALL",
"ACL LIST",
}

Expand Down