Skip to content

feat: display ROI in babydegen UI - #20

Merged
Tanya-atatakai merged 3 commits into
mainfrom
tanya/roi-in-babydegen
Jun 24, 2025
Merged

feat: display ROI in babydegen UI#20
Tanya-atatakai merged 3 commits into
mainfrom
tanya/roi-in-babydegen

Conversation

@Tanya-atatakai

Copy link
Copy Markdown
Contributor

Proposed changes

  1. update descriptions in libs that didn't have them
  2. fix Navbar tooltip (for some reason using separate component prevented the tooltip from showing, didn't figure why)
  3. move IS_MOCK_ENABLED to env vars
  4. display ROI in babydegen UI:

Loading state

Screenshot 2025-06-24 at 14 38 17

Shown value

Screenshot 2025-06-24 at 14 45 40

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Comment thread apps/babydegen-ui/src/components/Portfolio/Portfolio.tsx Outdated
Comment thread apps/babydegen-ui/src/components/Portfolio/Portfolio.tsx Outdated
Comment thread libs/ui-navbar/src/lib/Navbar.tsx Outdated
Comment thread libs/ui-theme/README.md Outdated
Comment thread libs/util-constants-and-types/README.md Outdated
import { mockChat } from '../../mocks/mockChat';
import { ChatResponse } from '../../types';

const IS_MOCK_ENABLED = process.env.IS_MOCK_ENABLED === 'true';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be abstracted in a util - saw usage in couple of other files.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, will do in next PRs 🙏

@Tanya-atatakai
Tanya-atatakai merged commit fe7ce14 into main Jun 24, 2025
2 checks passed
@Tanya-atatakai
Tanya-atatakai deleted the tanya/roi-in-babydegen branch June 24, 2025 13:36
@Tanya-atatakai Tanya-atatakai added the enhancement New feature or request label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants