Skip to content

feat: update agents to secure connection (http to https and 127.0.0.1 to localhost - #24

Merged
mohandast52 merged 5 commits into
mainfrom
mohan/update-agents-to-secure-connection
Jul 18, 2025
Merged

feat: update agents to secure connection (http to https and 127.0.0.1 to localhost#24
mohandast52 merged 5 commits into
mainfrom
mohan/update-agents-to-secure-connection

Conversation

@mohandast52

@mohandast52 mohandast52 commented Jul 14, 2025

Copy link
Copy Markdown
Contributor

Proposed changes

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@mohandast52 mohandast52 self-assigned this Jul 14, 2025
@mohandast52 mohandast52 added the enhancement New feature or request label Jul 14, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes local endpoints to use HTTPS with localhost instead of HTTP with 127.0.0.1 and introduces a temporary feature flag to control the WithdrawAgentsFunds component in the BabyDegen UI.

  • Updated LOCAL constants across libraries and apps to https://localhost:8716
  • Added IS_WITHDRAWAL_ENABLED flag and conditional rendering for withdrawals in App.tsx
  • Updated the BabyDegen UI README to reflect HTTPS dev server URL

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
libs/util-constants-and-types/src/lib/constants/local.ts Switched local constant to https://localhost:8716
apps/predict-ui/src/constants/urls.ts Updated LOCAL URL to HTTPS and localhost
apps/babydegen-ui/src/constants/urls.ts Updated LOCAL URL to HTTPS and localhost
apps/babydegen-ui/src/App.tsx Added IS_WITHDRAWAL_ENABLED flag, conditional rendering, and a TODO
apps/babydegen-ui/README.md Changed dev server URL to https://localhost:4200 in README
Comments suppressed due to low confidence (2)

apps/babydegen-ui/README.md:10

  • Document any additional setup required for HTTPS in development (e.g., trusting a self-signed certificate or configuring the dev server for HTTPS).
    - The app will be available at `https://localhost:4200`

apps/predict-ui/src/constants/urls.ts:1

  • The LOCAL constant is duplicated across multiple projects; consider centralizing it in a shared constants library to avoid inconsistencies.
export const LOCAL = 'https://localhost:8716';

Comment thread apps/babydegen-ui/src/App.tsx Outdated
Comment thread apps/babydegen-ui/src/App.tsx Outdated
@mohandast52
mohandast52 marked this pull request as ready for review July 14, 2025 08:18
Comment thread apps/babydegen-ui/src/App.tsx Outdated
Comment thread apps/babydegen-ui/src/constants/urls.ts Outdated
Comment thread apps/babydegen-ui/src/App.tsx Outdated

@Tanya-atatakai Tanya-atatakai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mohandast52
mohandast52 merged commit 23120e7 into main Jul 18, 2025
2 checks passed
@mohandast52
mohandast52 deleted the mohan/update-agents-to-secure-connection branch July 18, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants