Skip to content

Commit 9b09e65

Browse files
docs(review): drop unverifiable MECH_OFFCHAIN_URL from the use_offchain rationale
The comment on both task_submission_abci and task_execution referenced a MECH_OFFCHAIN_URL name that does not exist in this repo (it lives in mech-deployments/*.env and the metadata JSON pointed at by the on-chain mech). Rewords to "unless a client actually sends offchain requests to it" — the underlying claim (the enabled-but-unused handler is a no-op) is unchanged, but a reader of this codebase can now verify it without cross-repo lookups. Skill hashes cascade through mech_abci → agent → service via autonomy packages lock.
1 parent bf02375 commit 9b09e65

8 files changed

Lines changed: 18 additions & 18 deletions

File tree

packages/packages.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@
99
"connection/valory/websocket_client/0.1.0": "bafybeid4cnbjpmzcsw3usg7umufgqyod2u3xfw5uso3vukt3n5hfuxvdea",
1010
"skill/valory/contract_subscription/0.1.0": "bafybeicqlkmfpttw4hbbaakr6xos62rd6ytjwkyzlfli4xpvl5yqcycf6q",
1111
"skill/valory/delivery_rate_abci/0.1.0": "bafybeiathwdfpcfqbipqbkslv6j22q5cvov4n3czmehzij3czrhdnlg42e",
12-
"skill/valory/mech_abci/0.1.0": "bafybeiatxn2wb7pasde63hi4cghzoxzr6thj2xe3zwllr54f4kjx7b4ciq",
13-
"skill/valory/task_execution/0.1.0": "bafybeies2iytb73xae2t7k53ap4nzfdfvyqrglofjzdduv5ck4ptanxsjy",
14-
"skill/valory/task_submission_abci/0.1.0": "bafybeibdegmyw2pq54byeac7izj7vcm6egzhj6d72di7s3xdt3pfmai22i",
12+
"skill/valory/mech_abci/0.1.0": "bafybeigdwb6lsnj46goll73qzkeqcyffpv7sixf5oqwlfthl43htsybjia",
13+
"skill/valory/task_execution/0.1.0": "bafybeiba6ar75dz6ih36u6vwt3ksnvcibgxvxrq2ktedcp2b6rmvew563y",
14+
"skill/valory/task_submission_abci/0.1.0": "bafybeic3clyx66kfa3tdktzqiitr2kv5yk6qmqy6cuerumopweiigksabu",
1515
"skill/valory/websocket_client/0.1.0": "bafybeid6oyycsrvk4duftffs5mrfgmcepibt3qe4om3kfzhwhilfq3ynay",
16-
"agent/valory/mech/0.1.0": "bafybeidos57xj77zosblpmu2hsxkhczvotjwyxw2gwzhlumh3r6y7cyyxa",
17-
"service/valory/mech/0.1.0": "bafybeig5rxdfzpxvfheh6nvd5wnpkmktrfpzytefo6db66pwkvnpum7myi"
16+
"agent/valory/mech/0.1.0": "bafybeiab7emnojt4uglfdpk7x6x26wmnqs5azf7favs7qw3o3yebmkydxa",
17+
"service/valory/mech/0.1.0": "bafybeicjlkkltnpt4m3pse74e4fgq4lwbmbg7mx4ecdvmtsouzslmjbrxy"
1818
},
1919
"third_party": {
2020
"protocol/open_aea/signing/1.0.0": "bafybeifsjmldwyki3beqyvdt5lzenrg6wyrqaar5plc5rpnvtc4zlentye",

packages/valory/agents/mech/aea-config.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,12 @@ skills:
4040
- valory/abstract_abci:0.1.0:bafybeie5et43th2nta76cd3kpm3fmurd7oyzk3qxim76octvt56m6r2poi
4141
- valory/abstract_round_abci:0.1.0:bafybeifkxnvvgsldkb4rgejsoon2mvrmrnl7asy2nhenwss7hpwg3myflu
4242
- valory/contract_subscription:0.1.0:bafybeicqlkmfpttw4hbbaakr6xos62rd6ytjwkyzlfli4xpvl5yqcycf6q
43-
- valory/mech_abci:0.1.0:bafybeiatxn2wb7pasde63hi4cghzoxzr6thj2xe3zwllr54f4kjx7b4ciq
43+
- valory/mech_abci:0.1.0:bafybeigdwb6lsnj46goll73qzkeqcyffpv7sixf5oqwlfthl43htsybjia
4444
- valory/registration_abci:0.1.0:bafybeif4n2esdjvquomdkwktv7eolepskpo5jlqrfda2abxjqzy2ljsxzi
4545
- valory/reset_pause_abci:0.1.0:bafybeifrnmlscfiki7wojs6zasppefupd2wkjyq6orhdllfppjud7isrxi
4646
- valory/delivery_rate_abci:0.1.0:bafybeiathwdfpcfqbipqbkslv6j22q5cvov4n3czmehzij3czrhdnlg42e
47-
- valory/task_execution:0.1.0:bafybeies2iytb73xae2t7k53ap4nzfdfvyqrglofjzdduv5ck4ptanxsjy
48-
- valory/task_submission_abci:0.1.0:bafybeibdegmyw2pq54byeac7izj7vcm6egzhj6d72di7s3xdt3pfmai22i
47+
- valory/task_execution:0.1.0:bafybeiba6ar75dz6ih36u6vwt3ksnvcibgxvxrq2ktedcp2b6rmvew563y
48+
- valory/task_submission_abci:0.1.0:bafybeic3clyx66kfa3tdktzqiitr2kv5yk6qmqy6cuerumopweiigksabu
4949
- valory/termination_abci:0.1.0:bafybeih6sa2ttcvvjk7rcfn7ure2ws23kcfufssb4qmluzcfvednkfpvoi
5050
- valory/transaction_settlement_abci:0.1.0:bafybeihizaapype5sz7vlosms3nfo6jzfj4ujycuf5uthviq2otvmw6f6m
5151
- valory/websocket_client:0.1.0:bafybeid6oyycsrvk4duftffs5mrfgmcepibt3qe4om3kfzhwhilfq3ynay

packages/valory/services/mech/service.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ license: Apache-2.0
77
fingerprint:
88
README.md: bafybeihppqns2lwn5vehtqh2wu4tjyf76dbzxc26nlfws4sc5hcbjbalma
99
fingerprint_ignore_patterns: []
10-
agent: valory/mech:0.1.0:bafybeidos57xj77zosblpmu2hsxkhczvotjwyxw2gwzhlumh3r6y7cyyxa
10+
agent: valory/mech:0.1.0:bafybeiab7emnojt4uglfdpk7x6x26wmnqs5azf7favs7qw3o3yebmkydxa
1111
number_of_agents: 4
1212
deployment:
1313
agent:

packages/valory/skills/mech_abci/skill.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,11 @@ skills:
3030
- valory/abstract_round_abci:0.1.0:bafybeifkxnvvgsldkb4rgejsoon2mvrmrnl7asy2nhenwss7hpwg3myflu
3131
- valory/registration_abci:0.1.0:bafybeif4n2esdjvquomdkwktv7eolepskpo5jlqrfda2abxjqzy2ljsxzi
3232
- valory/reset_pause_abci:0.1.0:bafybeifrnmlscfiki7wojs6zasppefupd2wkjyq6orhdllfppjud7isrxi
33-
- valory/task_submission_abci:0.1.0:bafybeibdegmyw2pq54byeac7izj7vcm6egzhj6d72di7s3xdt3pfmai22i
33+
- valory/task_submission_abci:0.1.0:bafybeic3clyx66kfa3tdktzqiitr2kv5yk6qmqy6cuerumopweiigksabu
3434
- valory/termination_abci:0.1.0:bafybeih6sa2ttcvvjk7rcfn7ure2ws23kcfufssb4qmluzcfvednkfpvoi
3535
- valory/transaction_settlement_abci:0.1.0:bafybeihizaapype5sz7vlosms3nfo6jzfj4ujycuf5uthviq2otvmw6f6m
3636
- valory/delivery_rate_abci:0.1.0:bafybeiathwdfpcfqbipqbkslv6j22q5cvov4n3czmehzij3czrhdnlg42e
37-
- valory/task_execution:0.1.0:bafybeies2iytb73xae2t7k53ap4nzfdfvyqrglofjzdduv5ck4ptanxsjy
37+
- valory/task_execution:0.1.0:bafybeiba6ar75dz6ih36u6vwt3ksnvcibgxvxrq2ktedcp2b6rmvew563y
3838
behaviours:
3939
main:
4040
args: {}

packages/valory/skills/task_execution/models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,8 @@ def __init__(self, *args: Any, **kwargs: Any) -> None:
143143
# the coupling is deliberate. On-chain-only mechs that want
144144
# analytics writes (``mech_onchain`` source) still flip this on
145145
# and accept that their offchain HTTP handler is also live — the
146-
# handler is inert if no client's ``MECH_OFFCHAIN_URL`` points
147-
# at it, so the cost is a wire nothing rides rather than a
146+
# handler is inert unless a client actually sends offchain requests
147+
# to it, so the cost is a wire nothing rides rather than a
148148
# traffic-shape change. If an operator genuinely wants analytics
149149
# without ingress, that's a re-split of this flag and needs its
150150
# own review round, not an env override on the current shape.

packages/valory/skills/task_execution/skill.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ fingerprint:
1010
behaviours.py: bafybeihatg4ggqhrimoqbbgghiq7fbnenjbmgc6osxswplcingk3kg5bjm
1111
dialogues.py: bafybeid7bbtq3thsazuheoxwnli2lkpaiwgoeps7pwrw63apqg5dizuomm
1212
handlers.py: bafybeih6bh6mxxxvi2fs4dgvgmw4ovvwmwh7r57u7nuzqdv5q4unvggc2i
13-
models.py: bafybeih3es32osrundnhoguzursbc4zfde7qa27zmrkepdud24jffmrycy
13+
models.py: bafybeiatzqnv75vhmqa4srdfewyfzittjjearnn6noz3qfzr6ydcjhkdhy
1414
tests/__init__.py: bafybeieqltdoxt2ipgn7owrfyceylzqug3fpdy6pk6mxhdxyn2mujz4v7q
1515
tests/conftest.py: bafybeickrspufxtr47ndp5vbrkejmwutlv4swub6ai7ngyh6ejlsulxgom
1616
tests/test_behaviours.py: bafybeiezgysiwi54hbsoktrzhvktaolst4rkszyu57p7ezrjev7c3ckroa

packages/valory/skills/task_submission_abci/models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,8 @@ def __init__(self, *args: Any, **kwargs: Any) -> None:
131131
# the coupling is deliberate. On-chain-only mechs that want
132132
# analytics writes (``mech_onchain`` source) still flip this on
133133
# and accept that their offchain HTTP handler is also live — the
134-
# handler is inert if no client's ``MECH_OFFCHAIN_URL`` points
135-
# at it, so the cost is a wire nothing rides rather than a
134+
# handler is inert unless a client actually sends offchain requests
135+
# to it, so the cost is a wire nothing rides rather than a
136136
# traffic-shape change. The value is a duplicate of the flag
137137
# of the same name on ``task_execution``; if the two copies
138138
# drift (env override on one skill and not the other),

packages/valory/skills/task_submission_abci/skill.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ fingerprint:
1212
dialogues.py: bafybeicvqbqqviqhjkj4hfyqepanqzv6oa3nknpjaczs6yjpyxx5ilcbcq
1313
fsm_specification.yaml: bafybeicswghmdg7xsfhlgznsyr7zhydtunb2575qucxkxmeks6gcos3ut4
1414
handlers.py: bafybeieikfkrjtnlod35ldqf3veoe3oqha6fnnpqpkxwibi5jyobsnvd4a
15-
models.py: bafybeiegx7qustzak3oibom3yzphvismtb3cmsjlmmvmepp2p7pzsczxya
15+
models.py: bafybeihi4udsewau7p73t4vqnasywm5kicydrrggxcdz4skxoulfykvl5i
1616
payloads.py: bafybeiaaelmpfuv6pvuesj7iy2nnxvgxjketigrppurto2pbsoaqjum2ba
1717
predict_api_events_client.py: bafybeiaipvkrwitftwprsbrnj4rd6ac4n74qzvq22lscbb5li4efc2qnve
1818
rounds.py: bafybeifyjanb7hbqolgxsudzhr27otlaozgttjwufmqit6w5rgb2xc53yu
@@ -47,7 +47,7 @@ protocols:
4747
skills:
4848
- valory/abstract_round_abci:0.1.0:bafybeifkxnvvgsldkb4rgejsoon2mvrmrnl7asy2nhenwss7hpwg3myflu
4949
- valory/transaction_settlement_abci:0.1.0:bafybeihizaapype5sz7vlosms3nfo6jzfj4ujycuf5uthviq2otvmw6f6m
50-
- valory/task_execution:0.1.0:bafybeies2iytb73xae2t7k53ap4nzfdfvyqrglofjzdduv5ck4ptanxsjy
50+
- valory/task_execution:0.1.0:bafybeiba6ar75dz6ih36u6vwt3ksnvcibgxvxrq2ktedcp2b6rmvew563y
5151
behaviours:
5252
main:
5353
args: {}

0 commit comments

Comments
 (0)