New image source europeana - #808
Open
andreapasquali97 wants to merge 15 commits into
Open
Conversation
jlu5
reviewed
May 2, 2026
jlu5
reviewed
May 2, 2026
jlu5
reviewed
May 2, 2026
jlu5
reviewed
May 2, 2026
jlu5
reviewed
May 2, 2026
Co-authored-by: James Lu <hello@jlu5.com>
jlu5
reviewed
May 23, 2026
|
|
||
|
|
||
| class EuropeanaConfigurableSource(ConfigurableImageSource): | ||
| class EuropeanaConfigurableDownloader(EuropeanaDownloader): |
Member
There was a problem hiding this comment.
This should probably be a top level class (I'm not sure why it's laid out this way in the Unsplash downloader)
| return super(DefaultDownloader, self).get_folder_name() | ||
|
|
||
| def get_europeana_api_url(self): | ||
| return super().get_europeana_api_url() |
Member
There was a problem hiding this comment.
This function shouldn't be needed as all it does is call its parent
| return _("Fetch artwork images from Europeana.eu for a given keyword") | ||
|
|
||
| def get_source_name(self): | ||
| return "Europeana" |
Member
There was a problem hiding this comment.
Suggested change
| return "Europeana" | |
| return "europeana" |
seems we always use lowercase for sources by convention
|
|
||
| logger = logging.getLogger("variety") | ||
|
|
||
| random.seed() |
Member
There was a problem hiding this comment.
This shouldn't be needed, random is automatically seeded by default
|
|
||
| DESCRIPTION = _("Europe's digital cultural heritage from Europeana.eu") | ||
|
|
||
| # This API key has been requested from Andrea Pasquali to Europeana.ue in order to use it for Variety project |
Member
There was a problem hiding this comment.
Suggested change
| # This API key has been requested from Andrea Pasquali to Europeana.ue in order to use it for Variety project | |
| # This API key has been requested from Andrea Pasquali to Europeana.eu in order to use it for Variety project |
| return self.config | ||
|
|
||
| def get_folder_name(self): | ||
| return super(DefaultDownloader, self).get_folder_name() |
Member
There was a problem hiding this comment.
I think this function override isn't needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Europeana as new image source
Description
This PR adds Europeana API integration as a new image source.
Features
API Compliance
This implementation follows Variety's contribution guidelines:
Testing
Notes