Fixed playlist fetching - #49
Open
cameron-h-price wants to merge 3 commits into
Open
Conversation
updated parse_playlist to handle missing/None tracks field
modified get_current_user_playlist to allow pagination of results
added utils.ensure_username to get_current_user_playlists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I've been using this package and ran into a few bugs which I've fixed in this PR. Happy to discuss any of the changes before merging.
Bugs Fixed
1.
KeyError: 'tracks'on playlist searchWhen searching with
qtype=playlist, the tool was crashing becauseparse_playlisttried to accessplaylist_item['tracks']directly. Spotify's search results can return playlist items wheretracksisNone. Fixed by using.get('tracks') or {}and safely accessing nested keys.2. Playlist pagination — only first 50 playlists returned
get_current_user_playlistswas only fetching the first page of results. Fixed by following Spotify'snextcursor to paginate through all playlists.3.
user_is_owneralways returningFalseBecause
get_current_user_playlistswasn't decorated with@ensure_username,self.usernamewasNonewhenparse_playlistran the owner comparison. Fixed by adding the@utils.ensure_usernamedecorator.Thanks for the package!