Fix macOS/Linux sidecar build script and desktop setup docs#25
Open
adilzubair wants to merge 1 commit into
Open
Fix macOS/Linux sidecar build script and desktop setup docs#25adilzubair wants to merge 1 commit into
adilzubair wants to merge 1 commit into
Conversation
|
@adilzubair is attempting to deploy a commit to the Vasu-Devs' projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
This overlaps with the existing PR that fixes the incorrect This PR also includes a few follow-up improvements:
If maintainers prefer, I’m happy to narrow this PR to the non-overlapping follow-up changes only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the macOS/Linux sidecar build flow and update the desktop contributor setup docs to match the actual required steps.
This change fixes
scripts/build-sidecar.shso it produces the resource layout Tauri expects, uses repo-local cache directories during the sidecar build, and fails clearly if the expected sidecar binary is missing.It also updates
README.mdandCONTRIBUTING.mdso first-time contributors know they need to build the packaged sidecar resource before runningnpm run tauri dev.Type of Change
Testing
Commands run:
npm run typechecknpm testnpm run buildbackend/.venv/Scripts/python.exe -m pytest backend/testscd src-tauri && cargo checkbash scripts/build-sidecar.shPrivacy And Safety
Notes For Reviewers
This is a focused contributor-experience fix.
The main behavior change is in the macOS/Linux Bash sidecar helper, which now mirrors the working PowerShell flow more closely. The doc updates are intentionally small and only cover the missing step needed for full desktop setup.