Skip to content

fix(vector): use dedicated annotations for headless service #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iarlyy wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(vector): use dedicated annotations for headless service #536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/vector/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ helm install <RELEASE_NAME> \
| serviceAccount.automountToken | bool | `true` | Automount API credentials for Vector's ServiceAccount. |
| serviceAccount.create | bool | `true` | If true, create a ServiceAccount for Vector. |
| serviceAccount.name | string | `nil` | The name of the ServiceAccount to use. If not set and serviceAccount.create is true, a name is generated using the fullname template. |
| serviceHeadless.annotations | object | `{}` | Set annotations on Vector's Headless Service. |
| serviceHeadless.enabled | bool | `true` | If true, create and provide a Headless Service resource for Vector. |
| shareProcessNamespace | bool | `false` | Specify the [shareProcessNamespace](https://kubernetes.io/docs/tasks/configure-pod-container/share-process-namespace/) options for Vector Pods. |
| terminationGracePeriodSeconds | int | `60` | Override Vector's terminationGracePeriodSeconds. |
Expand Down
11 changes: 11 additions & 0 deletions charts/vector/ci/serviceHeadless-annotations-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Test serviceHeadless with custom annotations
## Values file for testing serviceHeadless annotations independent from service annotations.

service:
enabled: true
annotations:
service-annotation: "service-value"
serviceHeadless:
enabled: true
annotations:
headless-annotation: "headless-value"
2 changes: 1 addition & 1 deletion charts/vector/templates/service-headless.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ metadata:
labels:
{{- include "vector.labels" . | nindent 4 }}
annotations:
{{- with .Values.service.annotations }}
{{- with .Values.serviceHeadless.annotations }}
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
Expand Down
2 changes: 2 additions & 0 deletions charts/vector/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,8 @@ service:
serviceHeadless:
# serviceHeadless.enabled -- If true, create and provide a Headless Service resource for Vector.
enabled: true
# serviceHeadless.annotations -- Set annotations on Vector's Headless Service.
annotations: {}

# Configuration for Vector's Ingress.
ingress:
Expand Down