feat: generate type maps.#1787
Draft
LeviticusMB wants to merge 2 commits into
Draft
Conversation
Author
|
BTW that tool I was talking about is now available at https://github.com/Divine-Software/divine-companions/tree/master/judgement-cli. |
Member
|
Thanks for the pull request. |
Member
|
The tests fail so I mark this as draft for now. |
Author
|
Yeah sorry I intended to fix a few issues that I had noticed and add tests for it, but I've not yet taken the time to do so. Pleased to hear that you will consider the PR though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm testing the waters here; not sure how you feel about this. I could maintain a fork of course, but I'd prefer not to ...
This PR adds support for generating some schema metadata in addition to the actual JSON schema. The metadata could be used to generate type-safe validation functions directly by a tool that embeds this library.
To demonstrate, I also added a CLI option
-mthat writes out a TypeScript "type map"—similar to how "event maps" are often used when definingon()oraddEventListener():This type map makes it possible to define the following function:
which, in turn, may be used like this:
(That is, inside the
ifbranch, TypeScript now knows thatobjisMyObject, and the editor can show completions for thetypeargument tois().)