fix: unions where member lacks discriminator#2424
Open
bennypowers wants to merge 1 commit into
Open
Conversation
Allows discriminated unions where some members lack the discriminator
field entirely, as required by projects like custom-elements-manifest.
Example:
```ts
interface WithDiscriminator { type: "A"; value: string }
interface WithoutDiscriminator { value: number }
/** @Discriminator type */
type MyUnion = WithDiscriminator | WithoutDiscriminator;
```
The generated schema uses if/then conditions:
- If discriminator field is present -> match type WithDiscriminator
- If discriminator field is absent -> match type WithoutDiscriminator
Previously this threw "Cannot find discriminator keyword 'type' in type
WithoutDiscriminator"
but this is now valid for projects like custom-elements-manifest where
some union members naturally lack the discriminator field.
Changes:
- Separate union members into those with/without discriminator field
- Generate if/then conditions for types with discriminator (unchanged)
- Generate single if/then with anyOf for types without discriminator
- Only require discriminator field if all union members have it
- Handle empty properties case when all types lack discriminator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows discriminated unions where some members lack the discriminator field entirely, as required by projects like custom-elements-manifest.
Example:
The generated schema uses if/then conditions:
Previously this threw "Cannot find discriminator keyword 'type' in type WithoutDiscriminator"
but this is now valid for projects like custom-elements-manifest where some union members naturally lack the discriminator field.
Changes: