fix: preserve array and tuple structure in mapped types#2515
Open
puckey wants to merge 2 commits into
Open
Conversation
arthurfiorette
requested changes
Mar 30, 2026
1742864 to
5dd665f
Compare
When a mapped type like `{ [K in keyof T]: F<T[K]> }` operates on an
array or tuple, TypeScript preserves the array/tuple structure. The
schema generator was instead producing objects with numeric string keys.
- Detect `keyof` constraint resolving to `number` (array) and produce ArrayType
- Detect `keyof` constraint resolving to numeric literal union (tuple) and
produce TupleType
5dd665f to
2f21153
Compare
Contributor
Author
|
Rebased on next and ran tests. |
Collaborator
|
@puckey CI is failing |
Contributor
Author
|
Fixed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{ [K in keyof T]: F<T[K]> }operates on an array or tuple, TypeScript preserves the array/tuple structure, but the schema generator produced objects with numeric string keyskeyofconstraint resolving tonumber(array) and produceArrayTypekeyofconstraint resolving to numeric literal union (tuple) and produceTupleTypeTest plan
type-immutable-array—Immutable<Bar[]>produces array schema,Immutable<[string, number]>produces tuple schema,Immutable<Bar>with Map/Set branches resolves correctly