fix(ci): remove duplicate npm plugin from auto config#2525
Merged
Conversation
The bare "npm" plugin entry was left in place when 714fa1d added ["npm", { "setRcToken": false }], so the plugin is registered twice. auto's loadPlugins does no dedup, so the next hook runs twice, publishing two prereleases per release and joining them into one malformed GitHub release tag_name ("v...-next.14, v...-next.15") -> 422 not well-formed.
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Prerelease publishing to
nextsucceeds on npm but fails creating the GitHub release with:This has been failing on every release since the trusted-publishing change — GitHub Releases are stuck at v2.5.0 (Feb 4) while npm is at 2.9.1-next.15.
Root cause
714fa1dc("ci: use npm trusted publishing") added["npm", { "setRcToken": false }]but left the original bare"npm"entry in place, so the npm plugin is listed twice:auto'sloadPluginsdoes no dedup — it.apply()s every entry — so the plugin taps thenexthook twice. Each tap runs a fullnpm version+npm publish, so two prereleases are published per run (e.g.2.9.1-next.14andnext.15).auto'snext()then joins the whole result array into a single tag name:which it passes to the GitHub release API as
tag_name→ 422 "not well-formed".Fix
Remove the duplicate, keeping the
setRcToken: falseentry (correct for the OIDC trusted-publishing setup). This stops the double-publish and the malformed tag name. Existing missed GitHub releases won't be backfilled automatically, but future releases will create releases again.Version
Published prerelease version:
v2.9.1-next.16Changelog
🎉 This release contains work from new contributors! 🎉
Thanks for all your work!
❤️ Jonathan Puckey (@puckey)
❤️ Momo Kornher (@mrgrain)
❤️ _Kerman (@kermanx)
❤️ Ninjackson (@ninjack-dev)
❤️ Orgad Shaneh (@orgads)
❤️ Antonin CELESTIN (@aciwecloud)
🚀 Enhancement
🐛 Bug Fix
issuesandpull-requestswrite permissions to publish-auto workflow #2516 (@Copilot)inferin conditionals operating on function parameters #2495 (@ninjack-dev)additionalItemsin schema definitions #2477 (@aciwecloud)next🔩 Dependency Updates
Authors: 10