Skip to content

refactor(dashboard): make data table views opt-in - #4993

Merged
dlhck merged 2 commits into
minorfrom
make-table-views-opt-in
Jul 17, 2026
Merged

refactor(dashboard): make data table views opt-in#4993
dlhck merged 2 commits into
minorfrom
make-table-views-opt-in

Conversation

@dlhck

@dlhck dlhck commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Description

Makes saved data-table views opt-in via enableViews, with ListPage and the Settings Store opting in while scoped detail tables remain view-free by default. This prevents saved filters from leaking across entity-specific embedded tables and fixes the Settings Store's manual filter metadata, key filtering, and translated column headers. Regression coverage, Storybook examples, E2E expectations, and i18n source references are updated accordingly.

Breaking changes

hideViewsControls is replaced by the opt-in enableViews prop on DataTable and PaginatedListDataTable.

Screenshots

Not included.

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.

@vercel

vercel Bot commented Jul 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vendure-storybook Building Building Preview, Comment Jul 17, 2026 10:14am

Request Review

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0326a0a9-96c6-4c57-9715-fa3507d39bf9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch make-table-views-opt-in

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dlhck dlhck changed the title feat(dashboard): make data table views opt-in refactor(dashboard): make data table views opt-in Jul 17, 2026
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

Dashboard Preview: https://admin-dashboard-1yfo2tvok-vendure.vercel.app

@dlhck
dlhck marked this pull request as ready for review July 17, 2026 10:13
@vendure-developer-hub

vendure-developer-hub Bot commented Jul 17, 2026

Copy link
Copy Markdown

Docs previewPR merged

@dlhck
dlhck merged commit 41c91d9 into minor Jul 17, 2026
8 of 10 checks passed
@dlhck
dlhck deleted the make-table-views-opt-in branch July 17, 2026 10:15
@vendure-ci-automation-bot vendure-ci-automation-bot Bot locked and limited conversation to collaborators Jul 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant