revert: feat(asset-server-plugin) background color query param (#4999) - #5088
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Reverts the squash-merge of #4999 from
master.That PR adds a new
backgroundColorquery parameter to the asset server. It is a feature, so it belongs on theminorbranch rather than shipping in the next patch release frommaster. It was merged intomasterby mistake.The change is re-applied to
minorin a companion PR, which preserves the original author.git diffbetween this branch andb8004ae50(the commit immediately before the accidental merge) is empty forpackages/asset-server-plugin, so this restores the package to exactly its pre-merge state.A later
masterintominorbackmerge will not strip the feature back out ofminor. The merge sees no net change on themasterside for these files, because the feature and its revert cancel out, so the version onminoris kept. This was verified with a local trial merge: the feature survived and there were no conflicts inpackages/asset-server-plugin.Relates to #4999
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.