Skip to content

revert: feat(asset-server-plugin) background color query param (#4999) - #5088

Merged
michaelbromley merged 1 commit into
masterfrom
revert-pr-4999-from-master
Aug 4, 2026
Merged

revert: feat(asset-server-plugin) background color query param (#4999)#5088
michaelbromley merged 1 commit into
masterfrom
revert-pr-4999-from-master

Conversation

@michaelbromley

@michaelbromley michaelbromley commented Aug 4, 2026

Copy link
Copy Markdown
Member

Reverts the squash-merge of #4999 from master.

That PR adds a new backgroundColor query parameter to the asset server. It is a feature, so it belongs on the minor branch rather than shipping in the next patch release from master. It was merged into master by mistake.

The change is re-applied to minor in a companion PR, which preserves the original author.

git diff between this branch and b8004ae50 (the commit immediately before the accidental merge) is empty for packages/asset-server-plugin, so this restores the package to exactly its pre-merge state.

A later master into minor backmerge will not strip the feature back out of minor. The merge sees no net change on the master side for these files, because the feature and its revert cancel out, so the version on minor is kept. This was verified with a local trial merge: the feature survived and there were no conflicts in packages/asset-server-plugin.

Relates to #4999


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@vercel

vercel Bot commented Aug 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vendure-storybook Ready Ready Preview Aug 4, 2026 7:11am

Request Review

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 10e8142e-d420-4456-a349-29070242d8f8

📥 Commits

Reviewing files that changed from the base of the PR and between 0fec7bc and abd582b.

📒 Files selected for processing (7)
  • packages/asset-server-plugin/src/asset-server.ts
  • packages/asset-server-plugin/src/common.ts
  • packages/asset-server-plugin/src/config/image-transform-strategy.ts
  • packages/asset-server-plugin/src/config/preset-only-strategy.ts
  • packages/asset-server-plugin/src/transform-image.spec.ts
  • packages/asset-server-plugin/src/transform-image.ts
  • packages/asset-server-plugin/src/types.ts
 ___________________________________________________________________
< Find some code, review it up, all day long you'll have good luck! >
 -------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-pr-4999-from-master

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Aug 4, 2026

Copy link
Copy Markdown

@michaelbromley
michaelbromley merged commit c6076eb into master Aug 4, 2026
29 of 32 checks passed
@michaelbromley
michaelbromley deleted the revert-pr-4999-from-master branch August 4, 2026 07:18
@vendure-ci-automation-bot vendure-ci-automation-bot Bot locked and limited conversation to collaborators Aug 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant