update server code to work with async apiclient#27
Open
thomas-fossati wants to merge 2 commits into
Open
Conversation
added 2 commits
January 16, 2025 15:28
Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
thomas-fossati
requested review from
Arnaud-de-Grandmaison-ARM and
paulhowardarm
January 22, 2025 17:29
Arnaud-de-Grandmaison-ARM
approved these changes
Jan 22, 2025
Arnaud-de-Grandmaison-ARM
left a comment
Arnaud-de-Grandmaison-ARM
left a comment
Collaborator
There was a problem hiding this comment.
This all looks good to me !
paulhowardarm
approved these changes
Jan 23, 2025
paulhowardarm
left a comment
paulhowardarm
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Thanks for the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is paired with veraison/rust-apiclient#22 which modifies the apiclient library to be async.