fix(gateway): add error handling for oidc refresh#11475
Merged
Conversation
gr2m
reviewed
Dec 30, 2025
| } catch { | ||
| return null; | ||
| } catch (error) { | ||
| return { oidcError: error }; |
Collaborator
There was a problem hiding this comment.
Why not simply remove the try/catch block here and then introduce a try/catch around getGatewayAuthToken()?
gr2m
approved these changes
Dec 30, 2025
gr2m
added
backport
gr2m
added
ai/provider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
any error encountered while refreshing the oidc token was being silently ignored. this PR surfaces the error to the user
Summary
catch the error and pass it to the user
Manual Verification
add unit test
Checklist
pnpm changesetin the project root)