fix(amazon-bedrock): return request body from doGenerate and doStream#14258
Open
giulio-leone wants to merge 1 commit intovercel:mainfrom
Open
fix(amazon-bedrock): return request body from doGenerate and doStream#14258giulio-leone wants to merge 1 commit intovercel:mainfrom
giulio-leone wants to merge 1 commit intovercel:mainfrom
Conversation
Add `request: { body: args }` to the return objects of both
`doGenerate()` and `doStream()` in BedrockChatLanguageModel, matching
the pattern used by `@ai-sdk/anthropic` and other providers.
Previously the Bedrock provider omitted the request field (with a
`// TODO request?` comment in doStream), causing observability
frameworks like Mastra to receive `undefined` when reading
`request.body` for tracing span inputs.
Fixes vercel#13927
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tigent
bot
added
ai/provider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BedrockChatLanguageModel.doGenerate()anddoStream()were not returning arequestfield in their results. This meant consumers relying onrequest.body(e.g., for observability/tracing) receivedundefined.There was an existing
// TODO request?comment in thedoStreamreturn confirming this was a known gap.Changes
request: { body: args }to the return object ofdoGenerate()request: { body: args }to the return object ofdoStream()(replacing the TODO comment)This matches the pattern used by
@ai-sdk/anthropicand other providers.Test Plan
should include request bodyfor bothdoGenerateanddoStream)resultsnapshots now include the newrequestfield)Fixes #13927