fix: add experimental_onToolCallStart/Finish to AgentCallParameters type#14348
Open
Christian-Sidak wants to merge 1 commit intovercel:release-v6.0from
Open
fix: add experimental_onToolCallStart/Finish to AgentCallParameters type#14348Christian-Sidak wants to merge 1 commit intovercel:release-v6.0from
Christian-Sidak wants to merge 1 commit intovercel:release-v6.0from
Conversation
The AgentCallParameters type was missing experimental_onToolCallStart and experimental_onToolCallFinish callback properties. These callbacks already worked at runtime (flowing through the rest spread into generateText/streamText) but caused TypeScript errors when passed to agent.generate() or agent.stream(). Fixes vercel#14278
tigent
bot
added
ai/core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
experimental_onToolCallStartandexperimental_onToolCallFinishoptional callback properties to theAgentCallParameterstypeagent.generate()These callbacks already worked at runtime (flowing through the
...optionsrest spread intogenerateText/streamText) but were missing from the TypeScript type, forcing consumers to useas any.Fixes #14278
Test plan
tool-loop-agent.test-d.tspasses