fix(core): default tool-call input to empty object when undefined in convertToModelMessages#14356
Open
hijingsong wants to merge 1 commit intovercel:mainfrom
Open
fix(core): default tool-call input to empty object when undefined in convertToModelMessages#14356hijingsong wants to merge 1 commit intovercel:mainfrom
hijingsong wants to merge 1 commit intovercel:mainfrom
Conversation
…odelMessages When a tool has no parameters, the UI message part omits `input`. convertToModelMessages propagated this omission, causing OpenAI to reject the request with "Missing required parameter: arguments". Now defaults to empty object. Fixes vercel#14349
tigent
bot
added
ai/provider
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| ? (part.input ?? | ||
| ('rawInput' in part ? part.rawInput : undefined)) | ||
| : part.input, | ||
| : (part.input ?? {}), |
Contributor
There was a problem hiding this comment.
The output-error branch in convert-to-model-messages.ts can produce undefined for the tool-call input field when both part.input and part.rawInput are undefined, causing OpenAI to reject the request with "Missing required param".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a tool takes no parameters, the UI message part omits
input.convertToModelMessagespropagated this asundefined, causing OpenAI to reject the request with:Fix
In
convertToModelMessages, when building tool-call parts for non-error states, defaultinputto{}whenundefined:This ensures the tool-call always has a valid
inputvalue (empty object when no parameters are needed), which serializes to"arguments": "{}"for OpenAI compatibility.Testing
inputpresent (no regressions)output-errorpath already handlesundefinedinput viarawInputfallback — this fix applies the same pattern to the non-error pathFixes #14349