Properly set response-based OTEL attributes with adapters

[mischnic]

This fixes some of the failures (particularly the ones where a 500 returned from an App API route showed up as status:200 in OTEL).
But the newly added tests have more failures that I skipped for now

next.js/packages/next/src/build/templates/app-route.ts

Lines 289 to 296 in 6f4d94a

	const invokeRouteModule = async (span?: Span) => {
	return routeModule.handle(nextReq, context).finally(() => {
	if (!span) return
	span.setAttributes({
	'http.status_code': res.statusCode,
	'next.rsc': false,
	})

  return routeModule.handle(nextReq, context).finally(() => { // <-- handle() returns the response object from the user code
        if (!span) return
        span.setAttributes({
          'http.status_code': res.statusCode,          // <---------- this is using some default response object, not what handle() returned
          'next.rsc': false,
        })

[mischnic]

• Properly set response-based OTEL attributes with adapters  #94603 👈 (View in Graphite)
• canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Failing test suites

Commit: 915b465 | About building and testing Next.js

pnpm test-start test/production/app-dir/metadata-static-route-cache/metadata-static-route-cache.test.ts (job)

• app dir - metadata static routes cache > should generate different content after replace the static metadata file (DD)

Expand output

● app dir - metadata static routes cache › should generate different content after replace the static metadata file

next already started

  65 |   ) {
  66 |     if (this.childProcess) {
> 67 |       throw new Error('next already started')
     |             ^
  68 |     }
  69 |
  70 |     this._cliOutput = ''

  at NextStartInstance.start (lib/next-modes/next-start.ts:67:13)
  at Object.start (production/app-dir/metadata-static-route-cache/metadata-static-route-cache.test.ts:17:16)

[github-actions]

Stats cancelled

Commit: 915b465
View workflow run