Merged
Conversation
Br0wnHammer
added
enhancement
## Changes
- Extract shared batch_delete_expired() utility to eliminate duplicate
batched-delete logic in mcp_audit.py and mcp_approvals.py
- Reuse existing callAIGateway() helper in automationWorker.ts instead
of duplicating fetch calls with inline headers
- Parallelize audit + approval cleanup calls with Promise.all()
- Remove dead code (unreachable return in get_approved_request)
- Make PageHeaderExtendedProps.children optional to remove >{null}</ hack
- Prevent duplicate pending approval requests: reuse existing pending
request for same agent+tool instead of creating duplicates on retry
## Benefits
- Less duplicated code across Python CRUD and TypeScript worker
- Cleaner approval queue (no flood of identical pending requests)
- Faster cleanup job execution via parallel HTTP calls
…ages Take develop's structure (children inside PageHeaderExtended, updated Select ids and onChange types). Drop size="small" on Chip per develop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
AI gateway > MCP Gateway > Audit loginstead ofAI gateway / Mcp / AuditGET /v1/mcp/approvals/{id}/status), and approved-request bypass on re-submissionmcp_audit_cleanupjob (daily 3AM) that purges both audit logs and approval requestsPlease ensure all items are checked off before requesting a review: