Fix regression testing false negative - #3255
Merged
Merged
Conversation
The QoR parsing script returned -1 in case of a mismatch between arch file name in the actual run and the golden results. If there was 1 run failures, the -1 would cancel the 1 and as a result the regression tests would pass while having errors. This commit fixes that by not throwing an exception in that specific case (Therefore not returning -1) and taking the absolute value of the QoR and run failures.
github-actions
Bot
added
scripts
Contributor
Author
|
Just to add, the only reason all the strong tests were actually ran in the linked CI run was that the scatter gather tests were at the end of the task list. If you moved it to the beginning, the script would crash at the start, no other tasks would be run, and CI would've still passed. |
Contributor
Author
|
Changed the error message to be more consistent with the other error messages: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3254 . See this action run:
https://github.com/verilog-to-routing/vtr-verilog-to-routing/actions/runs/17196322572/job/48779145751
The test has passed the CI but there are actually errors:
Why did it pass? Well there this piece of code:
But that's not the root cause. The QoR parsing script returned -1 in case of a mismatch between arch file name in the actual run and the golden results. In case of 1 run failure, the -1 would cancel the 1 and as a result the regression tests would pass while having errors. This commit fixes that by not throwing an exception in that specific case (Therefore not returning -1) and taking the absolute value of the QoR and run failures before summing them up.