Removing Top Module Mapping With Slang - #3259
Merged
Merged
Conversation
loglav03
changed the title
loglav03
marked this pull request as ready for review
August 28, 2025 22:26
AlexandreSinger
approved these changes
Aug 29, 2025
AlexandreSinger
left a comment
AlexandreSinger
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @loglav03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed all top module mapping code in synthesis.tcl and slang_filelist.tcl for Slang.
Related Issue
Motivation and Context
Since top module mapping isn't required for slang, any unused code for this that made it to master needs to be removed to reduce clutter.
How Has This Been Tested?
Passes the system verilog regression test that uses slang as a parser.
Types of changes
Checklist: