[WIP] Add clang-tidy checks to CI

[AmirhosseinPoolad]

Adds automatic linter runs for vpr, libarchfpga and librrgraph to CI. Should wait until #3551 and #3552 are merger before this.

[AlexandreSinger]

A lot of the warnings and errors I see in the lint test I think are resolved in this PR that I was working on: #3527

Let me know if you have any comments.

[AmirhosseinPoolad]

It takes *way* too long to run this in the CI. Not sure if I like it.

[AlexandreSinger]

It takes way too long to run this in the CI. Not sure if I like it.

My guess is that clang-tidy is actually running clang under the hood to do this (actually I am almost certain it is). I wonder if we can cache that build like we do the other builds.

[hzeller]

For caching, I have written a clang-tidy runner that runs clang-tidy in parallel and also builds a directory where it caches results; so next time around it only has to process changed files or files that depend on changed files.
Using the github cache, you can use that to restore the cache, then next time it will be fast.

https://github.com/hzeller/dev-tools/blob/main/run-clang-tidy-cached.cc

Might be interesting to play with.

[AmirhosseinPoolad]

For caching, I have written a clang-tidy runner that runs clang-tidy in parallel and also builds a directory where it caches results; so next time around it only has to process changed files or files that depend on changed files. Using the github cache, you can use that to restore the cache, then next time it will be fast.

https://github.com/hzeller/dev-tools/blob/main/run-clang-tidy-cached.cc

Might be interesting to play with.

Thanks a lot! This should be very helpful.

[vaughnbetz]

No rush, but are you still working to get this in @AmirhosseinPoolad ?