[WIP][Tatum] Added routing delays from master to generated clocks - #3614
Open
AlexandreSinger wants to merge 3 commits into
Open
[WIP][Tatum] Added routing delays from master to generated clocks#3614AlexandreSinger wants to merge 3 commits into
AlexandreSinger wants to merge 3 commits into
Conversation
From verifying the output of Tatum and OpenSTA, I found that for generated clocks, OpenSTA usually includes the delays from the master clocks to the generated clocks in the timing paths; however, in Tatum we were not doing that. This exposes a limitation in Tatum that we need to start our traverals at nodes with no incoming edges (so they end up at level 0 of the traversal). To support generated clocks logically, we would have to start our traversal at the master clock and then through the generated clock source; but that can be very messy and intrusive. We can get around this by disabling the timing edges leading into the generated clock node. This ensures it is at level 0. We can then account for the delay from the master clock by adding latency to the generated clock node equal to the path delay. This ensures that the analysis is efficient and correct. It may be confusing for the user if adding generated clocks implicitly added clock latency (even though it is equivalent), so I also updated the timing reports to reconstruct the path from the master clock to the generated clock. From the user's perspective, they would not know that we did this small optimization. I have added strong tests to ensure that this is working for routed clocks, as well as when there are clock latencies as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From verifying the output of Tatum and OpenSTA, I found that for generated clocks, OpenSTA usually includes the delays from the master clocks to the generated clocks in the timing paths; however, in Tatum we were not doing that.
This exposes a limitation in Tatum that we need to start our traverals at nodes with no incoming edges (so they end up at level 0 of the traversal). To support generated clocks logically, we would have to start our traversal at the master clock and then through the generated clock source; but that can be very messy and intrusive.
We can get around this by disabling the timing edges leading into the generated clock node. This ensures it is at level 0. We can then account for the delay from the master clock by adding latency to the generated clock node equal to the path delay. This ensures that the analysis is efficient and correct.
It may be confusing for the user if adding generated clocks implicitly added clock latency (even though it is equivalent), so I also updated the timing reports to reconstruct the path from the master clock to the generated clock. From the user's perspective, they would not know that we did this small optimization.
I have added strong tests to ensure that this is working for routed clocks, as well as when there are clock latencies as well.