Fix always false #ifdef that disabled incremental timing cost updates - #3733
Open
soheilshahrouz wants to merge 9 commits into
Open
Fix always false #ifdef that disabled incremental timing cost updates#3733soheilshahrouz wants to merge 9 commits into
soheilshahrouz wants to merge 9 commits into
Conversation
github-actions
Bot
added
VPR
Contributor
Author
|
titan_other
|
Contributor
|
Yay, thanks for looking into this Soheil! I have this issue tracked, but never had the time to look into it: #3548 |
AmirhosseinPoolad
approved these changes
Aug 2, 2026
Contributor
Author
|
Titan quick QoR (3 seeds)
|
soheilshahrouz
force-pushed
the
fix_incr_td_cost_update
branch
from
August 8, 2026 00:59
7823653 to
f7ece42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
place_timing_update.cpp,INCR_COMP_TD_COSTSis declared as a static constexpr bool variable, butupdate_timing_cost()checked it with#ifdef INCR_COMP_TD_COSTS. Since a constexpr variable is not a preprocessor macro, the#ifdefwas always false, causing the timing costs to be computed from scratch.