Handle non-sink leaves when reloading tracebacks - #3790
Open
sleepybishop wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
VPR
sleepybishop
marked this pull request as ready for review
August 29, 2026 19:34
Contributor
|
Thanks for the PR! We would need end to end regression test of a circuit and architecture pair that fails in current master but passes with this change before we can merge this. We explain how this is done here: The unit test is unfortunately not helpful, please remove it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in traceback reloading. A traceback branch ends when its switch is undefined. Previously, it assumed most branches end at SINK nodes, but non-configurable routing can also leave a non-SINK leaf in the route tree. This is related to the refactoring in #3672.