Fix: preserve session data during impersonation#22
Conversation
Removes aggressive session flushing from `PossessionManager::logoutAndDestroySession` which was destroying unrelated application state (e.g., shopping carts) and disrupting multi-guard environments during user context switching. Adds `SessionFlushTest` to ensure that standard session data is properly preserved when starting and stopping an impersonation session. Co-authored-by: insign <1113045+insign@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 participant
Fix: preserve session data during impersonation
Removes aggressive session flushing from
PossessionManager::logoutAndDestroySessionwhich was destroying unrelated application state (e.g., shopping carts) and disrupting multi-guard environments during user context switching.Adds
SessionFlushTestto ensure that standard session data is properly preserved when starting and stopping an impersonation session.PR created automatically by Jules for task 16383101621677212612 started by @insign